fix(connection-catalogue): clean up engine card layout and naming - #605
Merged
Conversation
Engine cards now take their title from the engine rather than the first plugin in the group, with proper spellings for known engines (PostgreSQL, MongoDB Atlas, SQL Server) and title-cased fallback for the rest. Card layout reworked into two rows so the name no longer truncates and the meta line no longer wraps or gets clipped mid-word. The unavailable badge is shortened to a single word with the full sentence in a tooltip, and only the icon is dimmed so the text stays readable. Registry icons that fail to load now fall back to the generic database icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine cards in the connection catalogue had a handful of visual problems that showed up as soon as the registry had real content in it:
What changed
Cards are now titled after the engine, not whichever plugin happens to be first in the group.
engineDisplayName()maps known engines to their proper spelling (PostgreSQL, MongoDB Atlas, SQL Server, CSV, ...) and title-cases anything it doesn't know. Individual driver names still show where they belong: in the driver picker and the install screen.The card layout is reworked into two rows: icon, name and status badge on top, then a full-width meta line (paradigm, driver count, downloads) that ellipsizes instead of clipping. Names wrap to a second line rather than truncating, and the verified shield stays glued to the last word of the name instead of dropping to its own line.
For unsupported platforms the badge now just says "Unavailable" with the full sentence in a tooltip, and only the icon gets dimmed so the text stays readable. The "Install" hint is always visible instead of only appearing on hover.
New
RegistryDriverIconcomponent swaps in the generic database icon when a registry icon URL fails to load. Used by bothEngineCardandInstallGate.Notes
connectionCatalogue.unavailable, translated in all eight localesengineDisplayNameand the engine-based group titleparadigms; that needs fixing on the Tabularium side, not here