fix snk key passthrough in pp-plugin and pp-workflow-activity - #132
Open
zekelinAlex wants to merge 2 commits into
Open
fix snk key passthrough in pp-plugin and pp-workflow-activity#132zekelinAlex wants to merge 2 commits into
zekelinAlex wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
--SigningKeyFilePathbroke when snk auto-generation was added: the engine substitutes the value into the placeholder comparison inside the init script too, so pp-plugin always decided no key was passed and generated a fresh one (relative paths also resolved from the output folder, not from where dotnet new ran). In pp-workflow-activity the init script wasn't wired into template.json at all, so the key and--Companydid nothing.Now a provided key is found (relative paths are searched up the parent folders), copied into the project and referenced by file name in the csproj. A nonexistent path fails the post action. Without the parameter nothing changes.