chore: drop redundant OutputPath from PCF template - #130
Open
TomProkop wants to merge 1 commit into
Open
Conversation
TALXIS.DevKit.Build.Dataverse.Pcf.props already defaults OutputPath to this exact value ($(MSBuildProjectDirectory)\out\controls), so scaffolded PCF projects don't need to declare it themselves. Consumers building PCF controls aren't building .NET code at all (webpack/ pcf-scripts owns the actual build), so the template shouldn't carry MSBuild property clutter that has no function. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TALXIS.DevKit.Build.Dataverse.Pcf.props already defaults
OutputPathto$(MSBuildProjectDirectory)\out\controls, so the scaffolded PCF project doesn't need to declare it itself. Consumers of a PCF project aren't building .NET code at all (webpack/pcf-scripts owns the actual build), so the template shouldn't carry MSBuild property clutter with no function.Note:
TargetFramework/net462was already dropped from this template onmasterin a prior commit - verified empirically (scratch PCF control build via TALXIS.DevKit.Build.Sdk, Debug+Release) that PCF builds succeed fine relying purely on the SDK'snet472default; Microsoft.PowerApps.MSBuild.Pcf's own props/targets never reference TargetFramework at all.