Bump Microsoft.PowerApps.MSBuild tooling 1.x -> 2.10.1 - #110
Draft
TomProkop wants to merge 1 commit into
Draft
Conversation
A live nuget.org registry audit tonight found this repo's pinned Microsoft.PowerApps.MSBuild.* dependency versions had drifted stale against a major version: 1.48.2/1.50.1 vs the current 2.10.1, and the Plugin package used a "1.*" floating floor that can never resolve to the current 2.x major. - Directory.Build.props: MicrosoftPowerAppsTargetsVersion 1.48.2 -> 2.10.1 - PDPackage props/targets: default PdPackageMsBuildVersion 1.50.1 -> 2.10.1 (brings it back in line with MicrosoftPowerAppsTargetsVersion, which had drifted apart from it) - Plugin props: Microsoft.PowerApps.MSBuild.Plugin "1.*" -> "2.*" - docs/Tasks-Package.md: updated stale hardcoded example version Verified: dotnet pack of the modified Plugin/PdPackage/Solution/Tasks projects to a local feed, then dotnet restore of minimal consuming projects referencing each against that local feed + nuget.org confirms Microsoft.PowerApps.MSBuild.Plugin/PDPackage/Solution all resolve to 2.10.1 end-to-end through the updated version properties and nuspec substitutions. A dotnet build of the PdPackage-referencing project also exercised the PdPackage.props/.targets import chain successfully (only remaining error was an unrelated TargetFramework mismatch in the throwaway test project, not a tooling issue). Full scaffold-from-template builds (pp-plugin/pp-package/pp-solution via TALXIS.DevKit.Templates.Dataverse) were attempted but not completed end-to-end due to sandbox resource exhaustion (disk space) encountered partway through; the package-resolution verification above is the verification that was completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A live nuget.org registry audit tonight found this repo's pinned
Microsoft.PowerApps.MSBuild.*dependency versions had drifted stale against a major version bump:1.48.2/1.50.1vs the current2.10.1, and the Plugin package used a1.*floating floor that can never resolve to the current 2.x major.Changes:
src/Dataverse/Directory.Build.props:MicrosoftPowerAppsTargetsVersion1.48.2->2.10.1src/Dataverse/PDPackage/msbuild/build/TALXIS.DevKit.Build.Dataverse.PdPackage.{props,targets}: defaultPdPackageMsBuildVersion1.50.1->2.10.1(this had drifted apart fromMicrosoftPowerAppsTargetsVersionabove; both are now back in line)src/Dataverse/Plugin/msbuild/tasks/TALXIS.DevKit.Build.Dataverse.Plugin.props:Microsoft.PowerApps.MSBuild.Plugin1.*->2.*docs/Tasks-Package.md: updated stale hardcoded example versionThis is a major version bump of Microsoft's own MSBuild tooling (1.x -> 2.x), so there is real risk of breaking changes on Microsoft's side.
What I verified
dotnet packof the modifiedTALXIS.DevKit.Build.Dataverse.{Plugin,PdPackage,Solution,Tasks}projects to a local NuGet feed (using the modifiedDirectory.Build.props/.props/.targetsin this branch).dotnet restoreof minimal throwaway consumer projects referencing each ofTALXIS.DevKit.Build.Dataverse.Plugin,.PdPackage, and.Solutionagainst that local feed + nuget.org. All three restored cleanly andproject.assets.jsonconfirmsMicrosoft.PowerApps.MSBuild.Plugin,Microsoft.PowerApps.MSBuild.PDPackage, andMicrosoft.PowerApps.MSBuild.Solutionall resolved to2.10.1— i.e. the version property/nuspec-substitution plumbing correctly wires through to the new major version, and 2.10.1 genuinely exists and resolves on nuget.org.dotnet buildof the PdPackage-referencing throwaway project successfully imported the modifiedTALXIS.DevKit.Build.Dataverse.PdPackage.props/.targets, which in turn importedMicrosoft.PowerApps.MSBuild.PDPackage.props/.targets2.10.1 from the NuGet package cache without error (the only build error encountered was an unrelatedTargetFrameworkmismatch in the throwaway project —net472is required by the PDPackage tooling — not a tooling/versioning issue).grepacross the repo that no other file still references the old1.48.2/1.50.1/1.*values..props/.targetsfiles were confirmed to be well-formed XML.Not completed: a full end-to-end scaffold-and-build using the
TALXIS.DevKit.Templates.Dataversetemplates (pp-plugin,pp-package,pp-solution) against these locally-packed tooling packages. The template scaffold's PowerShell post-action hung indefinitely in the sandbox used for this verification, and the sandbox subsequently ran into disk exhaustion; given the package-resolution verification above already demonstrates the core risk (does 2.10.1 exist and resolve, does the version wiring work end-to-end), a full CRM-SDK plugin compile was not pursued further. Recommend a maintainer with a stable local dev environment do one real scaffold-and-build pass before merging, given this is a major-version bump of Microsoft's own tooling.Draft PR — not to be merged without that additional confirmation.
Generated by Claude Code