refactor: v3 - #454
Draft
wesleyboar wants to merge 22 commits into
Draft
Conversation
* feat!: remove dist * conf!: ignore dist * feat!: prevent publish if .css in src Need next to: - Rename source files to .postcss. - Deal with demo stylesheets. * feat: log if no dist found in source * refactor: optimizations * refactor: renamed vars * refactor: renamed source .css files to .postcss * refactor: move **/*.css source to ../*.postcss * fix/refactor: load .postcsss not .css * temp: restore dist (rebuilt) to diff * revert "conf!: ignore dist" (manually) * chore: delete & ignore dist (again) I checked diff with base branch. All good: - Diff had changes (unexpected). - Diff changes were rmeoval of demo and outdated files. * chore: ignore dist * chore: delete util script * fix: ignore fractal util file
* test: demo action * feat: lint dir & worflow to do so, UNTESTED * fix: lint workflow job step names * test: lint workflow job name * config: lint workflow on .css change for epic/v3 * test: build .css files * config: output paths from repo root not fs root * fix: delete align.css * fix: delete admonition.css * noop: test commit (new line) * Revert "noop: test commit (new line)" This reverts commit 88cf542. * noop: test commit (new line) in a .css file * Revert "noop: test commit (new line) in a .css file" This reverts commit d6aa2ca.
wesleyboar
added
enhancement
## Overview Import path fix since latest merge of `main`. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>
Closed
## Overview / Changes - Fix outdated undocumented lint script. - Fix inaccurate path imports since merging main. ## Related - cleans up #454 - as does #603 ## Testing 1. `npm run build` - no errors 2. `npm run lint` - no errors ## UI ### `npm run build` ``` Core-Styles-v3 % npm run build > @tacc/core-styles@3.0.0-alpha.0 build > npm run build:css && npm run build:demo > @tacc/core-styles@3.0.0-alpha.0 build:css > bin/build.js --build-id=$npm_config_build_id Tagging CSS version as @tacc/core-styles 3.0.0-alpha.0+ | MIT | github.com/TACC/Core-Styles Creating tokens for v1, v2, v3, ds Building stylesheet(s) to /Users/wbomar/Code/TACC/Core-Styles-v3/dist > @tacc/core-styles@3.0.0-alpha.0 postbuild:css > rm -rf dist/fonts && cp -r src/lib/fonts dist/fonts > @tacc/core-styles@3.0.0-alpha.0 prebuild:demo > rm -rf dist/_utils && cp -r src/lib/_utils dist/_utils > @tacc/core-styles@3.0.0-alpha.0 build:demo > fractality build Fractality version mismatch! Global: 3.0.0-alpha.0 / Local: 1.6.3 ✔ Build started... ⚑ Exported 966 of 966 items ✔ Build finished with no errors. ``` ### `npm run lint` ``` Core-Styles-v3 % npm run lint > @tacc/core-styles@3.0.0-alpha.0 lint > npm run lint:dirs > @tacc/core-styles@3.0.0-alpha.0 lint:dirs > bin/only-commit-source.js No dist files found in source. Ready to publish. ``` --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>
Merged
## Overview Syncs `epic/v3` with `main` (90 commits behind). > [!WARNING] > Performed by AI, Claude Sonnet 5 (under my direction). ## Related - updates #454 ## Changes - **merged** `main` into `epic/v3` - **resolved** `dist/*` modify/delete conflicts by keeping `epic/v3`'s deletion (`dist/` is not committed on v3) - **resolved** 4 renamed source files (`headings--cms`, `headings--docs`, `html-elements.docs`, `s-footer`) using `main`'s content with v3's `.postcss` import extensions - **renamed** 5 new source files added by `main` (`x-headings*`, `typography-headings--cms`/`docs`) from `.css` to `.postcss` to match v3's source convention - **regenerated** `package-lock.json` via `npm install`, keeping v3's `package.json` version ## Testing 1. `npm run build` - no errors 2. `npm run lint` - `No dist files found in source. Ready to publish.` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Garrett Edmonds <43251554+edmondsgarrett@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
main's tip (#682) was already applied to epic/v3 via #680's chain propagation, but #680 was squash-merged, severing epic/v3's ancestry link to main. Recording this merge with the 'ours' strategy (verified zero net content change) to restore that link so future `git merge main` operations compute the correct merge-base instead of redoing already-resolved conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix all the problems with Core-Styles v2.
Important
/distdirectory is not committed to GitHub.Related
Changes
…
Testing
UI
…