chore(tup): update CDN path for ad-hoc assets - #572
Merged
Conversation
wesleyboar
changed the title
Point ad-hoc CSS <link>s at Core-CMS-Custom@v1.6 instead of tup-ui, matching the swap already done for ad-hoc scripts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Update TUP assets to load from CDN via TACC/Core-CMS-Custom instead of TACC/tup-ui.
Related
Changes
Testing
Update snippets:
js-ad-hoc-scripts(dev)css-ad-hoc-styles(dev)UI
Skipped.
Notes
Note
@wesleyboar tested JavaScript.
Important
Claude AI tested CSS, and reported "10 of 13 byte-identical. 3 differ, all previously reviewed and expected" which is what I expected. (I had him verify the 3 differences he warned me about, which exist because live snippet uses the latest code from unmerged TACC/tup-ui PRs.) The functional differences are explained away by #564 "Testing" section.