Subtitle grid: triple-click a row to focus the text box without seeking (#11602)#11984
Closed
muaz978 wants to merge 1 commit into
Closed
Subtitle grid: triple-click a row to focus the text box without seeking (#11602)#11984muaz978 wants to merge 1 commit into
muaz978 wants to merge 1 commit into
Conversation
muaz978
force-pushed
the
feature/grid-triple-click-focus
branch
from
9c9ea98 to
5782830
Compare
…ng (SubtitleEdit#11602) A triple-click on a grid row now moves keyboard focus to the edit text box and leaves the video position untouched. Previously the third click arrived as a plain Tapped and re-fired the configured single-click action (which seeks). The third click is detected in the pointer-pressed handler via its click count, which cancels the pending single-click and marks the upcoming Tapped (or, on some platforms, DoubleTapped) as focus-only. The marker self-heals on the next fresh click sequence if that third tap is ever missed.
muaz978
force-pushed
the
feature/grid-triple-click-focus
branch
from
5782830 to
3a9cd71
Compare
Author
|
Rebased this branch onto the latest main. This is purely a sync, no functional changes: it just confirms this stays conflict-free and cleanly mergeable against current main. |
Member
|
Sorry, I'm not too sure about this... will close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtitle grid: triple-click to focus the text box without seeking
Implements suggestion #3 from #11602.
Problem
There was no quick way to jump from a grid row straight into editing its text without also moving the video position. Double-click runs the configured action (which seeks), and a third click just re-fired the single-click action.
Change
A triple-click on a grid row now moves keyboard focus to the edit text box and leaves the video position untouched.
Implementation notes
SubtitleGrid_PointerPressedviaPointerPressedEventArgs.ClickCount. When count reaches 3 on a valid row with the left button, it cancels the pending single-click timer and marks the upcoming tap as focus-only, then selects the row.Files
src/ui/Features/Main/MainViewModel.cs