Clarify task source categories and reconcile corrected creates - #712
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge decision: ready — a corrected source-category validation error can now yield a completed task-creation answer while retaining both failed attempts and the verified task receipt.
User outcome
Creating a task from a Gmail message previously rejected an external message ID supplied as
task_source_idorsource_id. A later successful correction still produced partial-completion finality. This change clarifies that both fields name a registered source category and that external provenance belongs innotesorreference_code.Native task:
#V#task_agent_2f3b1c23fb52c2ec365e826603aa2a8c.Material changes
Evidence
VON_USE_MOCK_DB=1 pdm run pytest tests/backend/test_coding_task_creation_recovery.py tests/backend/test_adaptive_turn_service.py tests/backend/test_task_ontology_service.py tests/backend/test_internal_mcp_task_parity_tools.py -q: 370 passed.git diff --checkandpdm lock --checkpass. Formatter differences in the ontology file are confined to unchanged lines.Ship boundary