Search conversation topics with title and participant priority - #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Conversations field previously filtered only loaded titles and participant IDs. It now combines those matches (including participant names) with the existing embedding-backed chat-content search. Title/participant matches always precede content-only results, including across API pagination; search results bypass the tray's recency and pin ordering. Typing is debounced, stale query/context responses are discarded, and failures preserve metadata matches with a retry.
Native task:
#V#task_agent_826a47c8faa2c0c77e8e24d3b568375c.Validation: 24 backend service/API tests and 15 frontend tests passed; changed-JavaScript static checks and diff checks passed.
tests/browser/conversationTopicSearch.cjspassed in Chromium against the candidate catalogue module with synthetic API replies, checking metadata precedence, an old unloaded topic match, query clearing and draft retention. This is fixture evidence, not live embedding-quality or authenticated production acceptance.The existing chat RAG index is reused; no migration or backfill was run. Message-exchange bodies are outside that index and retain loaded title/participant matching. Existing 500-conversation/10-owner retrieval bounds, index coverage, backfill routes and performance considerations are documented. No deployment requested. No secrets or runtime data committed.
Merge decision: ready for this bounded catalogue-to-chat-search integration; live index completeness remains unverified and is surfaced in the UI.