Repair file-copy workflow finality and governed recovery - #377
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
file_copy_concept_idand both workflow steps map that context value to the underlyingconcept_idtool argumentupsert_scoped_assertionrecovery action to governed canonical-write denialsnot_starteddenials only after an exact successful scoped recoveryRoot cause
The file-copy workflow publication required both legacy
concept_idandfile_copy_concept_idcontext keys even though the invoked tools accept one concept identifier. The workflow therefore failed metadata validation before executing. In the recovery path, governed denials were recorded asnot_started, but their generic recovery hint did not carry exact executable arguments and finality could not prove that the later scoped write recovered the denied semantic effect.Impact
A durable file copy can now launch the interpretation workflow with its single intended identifier. When canonical publication is correctly denied and an actor-scoped assertion succeeds, the turn reports the verified user outcome without misrepresenting the denied canonical mutation as successful.
Validation
tests/backend/test_adaptive_turn_service.py: 162 passedgit diff --check: passedKnown baseline limitation
Three scoped-assertion listing tests fail under
VON_USE_MOCK_DB=1because their visibility fixtures do not populate or stub the concept visibility batch. The exact failures reproduce onorigin/mainand this branch does not modify that service or those tests.