Update retired-controller tests for situation carriers - #331
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates backend test fixtures to stub the canonical chat-history session-state read (get_chat_history_session_state) introduced by the conversation-situation carrier work, replacing legacy stubs of the message-only get_chat_history seam. This keeps the “retired outer controller is not instantiated” assertions reachable by avoiding production-only Mongo query comment behaviour in the test double.
Changes:
- Replace
get_chat_historymonkeypatch stubs withget_chat_history_session_statestubs that return an empty session-state structure. - Update the namespace-propagation test to observe and assert namespace flow through the new session-state read path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Update the ordinary-generation test fixture to stub the canonical
get_chat_history_session_statecarrier read introduced by the conversation-situation work, rather than the retired message-onlyget_chat_historycall.Why
The tests that prove ordinary turns do not instantiate the retired universal conversation controller were failing before reaching that assertion because their mock history collection rejected production-only Mongo query comments. A second namespace-propagation test was still observing the obsolete read seam.
This changes test support only; production behaviour is unchanged.
Validation
27 passedacross:test_von_generate_workflow_instances.pytest_conversation_turn_workflow_vontology_service.pytest_workflow_turn_capability_service.pygit diff --checkpassed