Skip to content

Update retired-controller tests for situation carriers - #331

Merged
witbrock merged 1 commit into
mainfrom
agent/retired-controller-test-fixture
Jul 29, 2026
Merged

witbrock merged 1 commit into
mainfrom
agent/retired-controller-test-fixture

Conversation

@witbrock

Copy link
Copy Markdown
Member

What changed

Update the ordinary-generation test fixture to stub the canonical get_chat_history_session_state carrier read introduced by the conversation-situation work, rather than the retired message-only get_chat_history call.

Why

The tests that prove ordinary turns do not instantiate the retired universal conversation controller were failing before reaching that assertion because their mock history collection rejected production-only Mongo query comments. A second namespace-propagation test was still observing the obsolete read seam.

This changes test support only; production behaviour is unchanged.

Validation

  • 27 passed across:
    • test_von_generate_workflow_instances.py
    • test_conversation_turn_workflow_vontology_service.py
    • test_workflow_turn_capability_service.py
  • Ruff passed
  • git diff --check passed

Copilot AI review requested due to automatic review settings July 29, 2026 21:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates backend test fixtures to stub the canonical chat-history session-state read (get_chat_history_session_state) introduced by the conversation-situation carrier work, replacing legacy stubs of the message-only get_chat_history seam. This keeps the “retired outer controller is not instantiated” assertions reachable by avoiding production-only Mongo query comment behaviour in the test double.

Changes:

  • Replace get_chat_history monkeypatch stubs with get_chat_history_session_state stubs that return an empty session-state structure.
  • Update the namespace-propagation test to observe and assert namespace flow through the new session-state read path.

@witbrock
witbrock merged commit bdaafb9 into main Jul 29, 2026
5 checks passed
@witbrock
witbrock deleted the agent/retired-controller-test-fixture branch August 3, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants