Allow slower launcher health initialisation - #330
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the POSIX run.sh launcher so slow-but-healthy startups aren’t falsely reported as failed by increasing the default initial health wait, and adds a regression test to lock in the new default.
Changes:
- Increase
run.shdefaultHEALTH_TIMEOUT_SECfrom 60 to 180 seconds. - Update
run.sh helptext to display the new 180-second default for-HealthTimeoutSec. - Add a test asserting the default health timeout value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
run.sh |
Raises the default health timeout and updates help output to reflect the new default. |
tests/test_run_sh_start_behaviour.py |
Adds a regression test asserting the default HEALTH_TIMEOUT_SEC value. |
Comment on lines
+43
to
+54
| def test_run_sh_default_health_timeout_covers_slow_startup() -> None: | ||
| payload = _run_bash_probe( | ||
| r""" | ||
| python3 - <<PY | ||
| import json | ||
| print(json.dumps({"health_timeout_seconds": int("$HEALTH_TIMEOUT_SEC")})) | ||
| PY | ||
| """ | ||
| ) | ||
|
|
||
| assert payload == {"health_timeout_seconds": 180} | ||
|
|
Comment on lines
39
to
43
| LOG_RETENTION=20 | ||
| ADMIN_TOKEN="" | ||
| SKIP_HEALTH=0 | ||
| HEALTH_TIMEOUT_SEC=60 | ||
| HEALTH_TIMEOUT_SEC=180 | ||
| HEALTH_GRACE_SEC=45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
A measured healthy startup took 66.1 seconds, so the old 60-second default could report failure while Von was still initialising. The longer default retains the explicit
-HealthTimeoutSecoverride and the existing health-grace behaviour.Validation
29 passedintests/test_run_sh_start_behaviour.pybash -n run.shgit diff --check origin/main...HEADuv.lockis unrelated generated local residue and is not included.