JVNAUTOSCI-2592 preserve retry authority and bound KR read-back - #303
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes workflow-step retry policy durable across repo-seed export/drift surfaces and reduces KR concept read-back cost by removing an unnecessary relation-expansion request shape, while advancing the KR and dependent spreadsheet seed versions.
Changes:
- Export and drift-compare per-step
retry_policyso repo-seed upgrades preserve read-retry authority. - Update KR materialisation concept read-back to call
fetch_conceptwithout expensive relation/text-relation expansion flags, keeping the separate boundedget_text_relations(hasDescription)read. - Bump KR seed to v7 and spreadsheet programme seed to v20, updating dependent fingerprints and adding regressions.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/backend/test_workflow_repo_seed_export_service.py | Adds regression ensuring step retry_policy is preserved in publication-spec export payloads. |
| tests/backend/test_workflow_repo_seed_affordances.py | Adds drift-detection regression for missing per-step retry_policy. |
| tests/backend/test_spreadsheet_programme_workflow_vontology_service.py | Updates expected spreadsheet programme seed/dependency versions (v20 / KR v7). |
| tests/backend/test_kr_materialisation_workflow_vontology_service.py | Updates KR seed version expectation and adds bounded read-back shape regression. |
| src/backend/workflows/workflow_repo_seed_export_service.py | Serialises step retry_policy into exported publication-spec payloads. |
| src/backend/workflows/repo_seed_bundles/spreadsheet_programme_representation_workflow_seed_bundle.json | Advances spreadsheet seed version and updates dependent KR seed version + fingerprints. |
| src/backend/workflows/repo_seed_bundles/kr_materialisation_workflow_seed_bundle.json | Advances KR seed to v7 and removes relation/text-relation expansion bindings from concept read-back. |
| src/backend/services/workflow_repo_seed_bootstrap.py | Includes retry_policy in stable metadata subset used for materialisation drift comparison. |
| scripts/generate_spreadsheet_programme_workflow_seed.py | Advances generated spreadsheet programme seed version to v20. |
Comment on lines
+5
to
6
| "seed_version": "7", | ||
| "source_tag": "JVNAUTOSCI-2271", |
witbrock
force-pushed
the
codex/JVNAUTOSCI-2592-retry-policy-authority
branch
from
July 24, 2026 06:32
7dfef1d to
965b775
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Makes represented spreadsheet/KR materialisation retry authority durable across repo-seed upgrades and removes unnecessary Atlas-heavy relation expansion from deterministic concept and relationship read-back.
Live evidence
fetch_concepttimeout correctly retried once, proving executor semantics were sound.relationships; description evidence already has a separate predicate-scoped read.Changes
retry_policyin repo-seed authority export.retry_policyin materialisation drift comparison.fetch_concept; retain core relationship mappings and the separate boundedget_text_relations(hasDescription)read.Validation
git diff --checkpass.Safety
No workbook rows, names, values, file identifiers, or private concept identifiers are included. No write retry is introduced; only idempotent read states retry.