Skip to content

JVNAUTOSCI-2592 preserve retry authority and bound KR read-back - #303

Merged
witbrock merged 1 commit into
mainfrom
codex/JVNAUTOSCI-2592-retry-policy-authority
Jul 24, 2026
Merged

witbrock merged 1 commit into
mainfrom
codex/JVNAUTOSCI-2592-retry-policy-authority

Conversation

@witbrock

@witbrock witbrock commented Jul 24, 2026 •

Copy link
Copy Markdown
Member

Outcome

Makes represented spreadsheet/KR materialisation retry authority durable across repo-seed upgrades and removes unnecessary Atlas-heavy relation expansion from deterministic concept and relationship read-back.

Live evidence

  • A seed v6 upgrade advanced the live marker without storing either concept read retry policy because retry policy was omitted from export/fingerprint and drift-comparison surfaces.
  • After forced publication, a live fetch_concept timeout correctly retried once, proving executor semantics were sound.
  • Both attempts still exceeded 20 seconds. Telemetry showed the expanded read materialising a broad concept preview (about 825 concept rows), while the deterministic states consume only core relationships; description evidence already has a separate predicate-scoped read.
  • The relationship item had the same unused expansion twice per asserted edge.

Changes

  • Serialise state retry_policy in repo-seed authority export.
  • Include retry_policy in materialisation drift comparison.
  • Use canonical retry keys so publish/load/export round trips are stable.
  • Add an attested v6 legacy digest so the current reviewed live authority can migrate normally to v7.
  • Keep retries only on four leaf read states; writes and outer loops remain fail-fast.
  • Make deterministic concept/source/target read-back a plain exact fetch_concept; retain core relationship mappings and the separate bounded get_text_relations(hasDescription) read.
  • Add export, canonical round-trip, missing-policy drift, stale-marker migration, and bounded-read-shape regressions.
  • Advance KR seed to v7 and dependent spreadsheet authority to v20.

Validation

  • 17/17 full KR and spreadsheet Vontology service tests pass.
  • 21 focused reviewer tests pass.
  • Applicable repo-seed affordance tests pass 20/20; the intentionally excluded test requires a configured live/local DB support-concept lookup.
  • KR validate-all succeeds for all three workflows.
  • Ruff, JSON parse, and git diff --check pass.

Safety

No workbook rows, names, values, file identifiers, or private concept identifiers are included. No write retry is introduced; only idempotent read states retry.

Copilot AI review requested due to automatic review settings July 24, 2026 06:17
@witbrock
witbrock marked this pull request as ready for review July 24, 2026 06:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes workflow-step retry policy durable across repo-seed export/drift surfaces and reduces KR concept read-back cost by removing an unnecessary relation-expansion request shape, while advancing the KR and dependent spreadsheet seed versions.

Changes:

  • Export and drift-compare per-step retry_policy so repo-seed upgrades preserve read-retry authority.
  • Update KR materialisation concept read-back to call fetch_concept without expensive relation/text-relation expansion flags, keeping the separate bounded get_text_relations(hasDescription) read.
  • Bump KR seed to v7 and spreadsheet programme seed to v20, updating dependent fingerprints and adding regressions.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/backend/test_workflow_repo_seed_export_service.py Adds regression ensuring step retry_policy is preserved in publication-spec export payloads.
tests/backend/test_workflow_repo_seed_affordances.py Adds drift-detection regression for missing per-step retry_policy.
tests/backend/test_spreadsheet_programme_workflow_vontology_service.py Updates expected spreadsheet programme seed/dependency versions (v20 / KR v7).
tests/backend/test_kr_materialisation_workflow_vontology_service.py Updates KR seed version expectation and adds bounded read-back shape regression.
src/backend/workflows/workflow_repo_seed_export_service.py Serialises step retry_policy into exported publication-spec payloads.
src/backend/workflows/repo_seed_bundles/spreadsheet_programme_representation_workflow_seed_bundle.json Advances spreadsheet seed version and updates dependent KR seed version + fingerprints.
src/backend/workflows/repo_seed_bundles/kr_materialisation_workflow_seed_bundle.json Advances KR seed to v7 and removes relation/text-relation expansion bindings from concept read-back.
src/backend/services/workflow_repo_seed_bootstrap.py Includes retry_policy in stable metadata subset used for materialisation drift comparison.
scripts/generate_spreadsheet_programme_workflow_seed.py Advances generated spreadsheet programme seed version to v20.

Comment on lines +5 to 6
"seed_version": "7",
"source_tag": "JVNAUTOSCI-2271",
@witbrock
witbrock force-pushed the codex/JVNAUTOSCI-2592-retry-policy-authority branch from 7dfef1d to 965b775 Compare July 24, 2026 06:32
Copilot AI review requested due to automatic review settings July 24, 2026 06:32
@witbrock
witbrock merged commit 908e04a into main Jul 24, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

@witbrock
witbrock deleted the codex/JVNAUTOSCI-2592-retry-policy-authority branch July 28, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants