fix(gap): target axis gap properties#2315
Open
dancormier wants to merge 4 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 7f54ac6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What this PR does
!importantdeclaration to allgapproperty atomic classesWe expect all of our atomic classes to include
!importantso they override the given style of a component in all cases..gx*and.gy*atomic classes so they only impact the the CSS property for a single axis, as intended.Prior to this PR, those properties set a
gapproperty which included some value for both axes. This would result in the property potentially overwriting an existing gap value for the axis not intended to be set by the atomic class applied.Related Issue
STACKS-908
Changes
.g*classes to emitgap: var(--_gap-y, 0) var(--_gap-x, 0) !important..gx*classes to emitrow-gap: var(--_gap-x) !important..gy*classes to emitcolumn-gap: var(--_gap-y, 0) !important.gap.less.Testing
npm run lint:css -w packages/stacks-classicnpx vitest run lib/atomic/gap.less.test.ts -unpm run test:less -w packages/stacks-classic