docs: translate the site nav to Japanese and unify the footer - #255
Merged
Conversation
The Japanese build rendered the English `nav:` labels verbatim. The i18n plugin translates navigation only when the ja locale carries a `nav_translations` map, and this one had none; page bodies were already translated, so the menu was the last English surface on the ja site. Add the map for every nav entry, prefix the top-level entries and each page's H1 with an emoji, and give the footer the copyright and social links the SpriteStudio-Docs portal uses - with Japanese icon labels on the ja build. `nav_translations` keys are matched literally, so they carry the emoji too: a key that does not match its `nav:` title silently falls back to the English label rather than failing the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Japanese docs rendered the English
nav:labels verbatim. The i18n plugintranslates navigation only when the ja locale carries a
nav_translationsmap,and this repo had none — page bodies were already fully translated, so the menu
was the last English surface on the ja site.
nav_translationscovering every nav entry. Labels comefrom each page's own H1, and match the wording SSPlayerForUnity already uses
wherever the same English title appears in both repos.
SpriteStudio-Docs portal. Child entries stay emoji-free, as they do there.
copyrightplus the GitHub andOPTPiX SpriteStudio icons, with Japanese icon labels on the ja build.
Sibling PRs apply the same change to the other four docs sites, so all six
(including the portal) now share one nav and footer convention.
Notes
nav_translationskeys are matched literally, so they carry the emoji too. A keythat stops matching its
nav:title falls back to the English label silently— it does not fail the build — so the two lists have to move together.
Adding an emoji to an H1 prepends a hyphen to that heading's anchor id
(
#-license). The portal already generates ids that way, and nothing in thisrepo links to an H1 anchor, so no existing link changes.
Test plan
mkdocs build --strict— no warningsTranslated N navigation elements to 'ja'equals the total nav entry countextraoverride