Follow the SDK's Windows x64 directory rename - #252
Closed
Naruto wants to merge 1 commit into
Closed
Conversation
The SDK now names its Windows library directories the way Windows does (libs/windows/x64 instead of libs/windows/x86_64), so download-sdk.ps1 reads from the new path. The custom-module copies it makes keep their ssruntime.windows.<target>.x86_64.lib names: that is Godot's own artifact convention, not the SDK's layout.
Collaborator
Author
|
Not needed. The SDK PR dropped the The rename would have made Windows the only non-identity mapping in this download script, permanently, for a cosmetic gain. Keeping The SDK still starts shipping Windows arm64 libraries; that is purely additive and this script ignores the new directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on cri-middleware/SpriteStudio-SDK#342 — land that first.
The SDK now names its Windows library directories the way Windows does:
libs/windows/x64instead oflibs/windows/x86_64.download-sdk.ps1readsfrom the new path.
The custom-module copies it makes keep their
ssruntime.windows.<target>.x86_64.libnames: that is Godot's own artifactconvention (
godot.windows.editor.x86_64.exe), not the SDK's layout, so itstays on Godot's vocabulary.
The SDK also starts shipping Windows arm64 libraries in the same release. This
PR does not wire them up — that needs matching
.arm64.libmodule copies andbuild configuration, which is a Windows-on-ARM port rather than a path change.