Fix handling of 32-character SSID strings when scanning for access points on Esp8266 - #3032
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when scanning for access points on the Esp8266.
The code currently assumes that the SSID is NUL-terminated, but this cannot be relied upon.
I today started getting weird behaviour sending the network list over a websocket connection in JSON format.
If any of the JSON is malformed then the browser closes the connection.
The offending SSID was this:
The SSID buffer is only 32 characters long so the
20 06 beis junk which is not part of the name.Clearly the
ssid_lenshould have been used: we cannot assume SSID is NUL-terminated.