Skip to content

Fix Matrix-Game-3 pipeline exit handling#79

Draft
Arison591 wants to merge 1 commit into
SkyworkAI:mainfrom
Arison591:agent/return-matrix-game3-video
Draft

Fix Matrix-Game-3 pipeline exit handling#79
Arison591 wants to merge 1 commit into
SkyworkAI:mainfrom
Arison591:agent/return-matrix-game3-video

Conversation

@Arison591

Copy link
Copy Markdown

Summary

  • return the generated video from both Matrix-Game-3 pipeline variants
  • leave distributed-process-group cleanup to the top-level caller that initialized it
  • allow generate.py to run its synchronization, cleanup, and final log statements

Root cause and impact

Both MatrixGame3Pipeline.generate implementations called exit() after saving the output. This terminated the entire interpreter instead of returning control to the caller, so the final statements in generate.py were unreachable and the pipelines could not be embedded in another Python process. They also destroyed the process group internally even though generate.py already owns that lifecycle.

Closes #77.

Validation

  • python -m compileall -q Matrix-Game-3/generate.py Matrix-Game-3/pipeline/inference_pipeline.py Matrix-Game-3/pipeline/inference_interactive_pipeline.py
  • python -m ruff check Matrix-Game-3/generate.py Matrix-Game-3/pipeline/inference_pipeline.py Matrix-Game-3/pipeline/inference_interactive_pipeline.py --select F821,F822,F823
  • RTX 5090 CUDA regression with stubbed model components and zero generation iterations, confirming that both non-interactive and interactive generate() methods return normally instead of raising SystemExit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run logic error when finish

1 participant