Update SimpleITK release - #118
Conversation
6976ddb to
3ed1223
Compare
|
It looks like the error message in SimpleITK for the -std flag should be updated. You no not need to explicitly enable C++17 for SimpleITK. This change is heading down the wrong path the address the error. |
a5eeec2 to
f7b824b
Compare
|
HI @blowekamp, your observation was correct. The actual issue was with the AlmaLinux8 gcc version which was too old (version 8). It did have support for C++17, but that wasn't complete. Upgrading to gcc 13 resolved the issue. |
| harfbuzz-devel fribidi-devel libssh2-devel \ | ||
| curl tar | ||
| # Prepend GCC 13 to PATH so all subsequent steps (including R) use it | ||
| echo "/opt/rh/gcc-toolset-13/root/usr/bin" >> $GITHUB_PATH |
There was a problem hiding this comment.
There may be other env variable that should be set. The best practice is to run source scl_source enable gcc-toolset-13. That could be done right before the build to enable this tool change, it think.
Install GCC 13 for full C++17 compatibility on AlmaLinux 8. Replaces the default GCC 8 which has partial C++17 support which isn't sufficient for modern ITK.
|
What is the plan and strategy to manage 2.5 patch release along with 3.0 pre-releases? Separate branches? Some type of configuration? |
|
Closing this PR in favor of #119. |
2 participants
No description provided.