Skip to content

fixing text mode behaviour and adding \math command - #1

Closed
Shrookin wants to merge 1 commit into
pr/free-text-free-mathfrom
fix/text-mode-math-command
Closed

fixing text mode behaviour and adding \math command#1
Shrookin wants to merge 1 commit into
pr/free-text-free-mathfrom
fix/text-mode-math-command

Conversation

@Shrookin

@Shrookin Shrookin commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a \math{} command that parses its body as math inside prose, as the inverse of \text{}
  • remember whether LaTeX entry began in text or free-text and restore that prose mode after bounded or unbounded completion
  • allow nested LaTeX commands and spaces inside an open bounded entry, including \math{\forall x \land \frac{1}{2}}
  • keep math placeholders in math mode until they are filled
  • publish matching runtime bundles

PR structure

This is intentionally stacked on the free-text implementation from arnog#3060 so the diff directly covers both text and free-text. It can be retargeted after that prerequisite lands.

Verification

  • npx tsc --noEmit
  • npx jest test --runInBand (335 passed)
  • full Chromium physical-keyboard suite (48 passed)
  • focused source/watch tests in Chromium, Firefox, and WebKit (9 passed)
  • focused tests repeated against the checked-in dist/mathlive.mjs artifact in Chromium, Firefox, and WebKit (9 passed)
  • targeted ESLint and Prettier checks

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 18ecb837-2b5d-410a-ba13-fe71859651c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Shrookin

Shrookin commented Sep 7, 2026

Copy link
Copy Markdown
Owner Author

Closed in favor of the canonical upstream PR: arnog#3069

@Shrookin Shrookin closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant