Don't recompile regex on every call to api.utils.sanitizeShop() - #3323
Open
panzi wants to merge 1 commit into
Open
Don't recompile regex on every call to api.utils.sanitizeShop()#3323panzi wants to merge 1 commit into
panzi wants to merge 1 commit into
Conversation
sanitizeShop() recompiled multiple complex regular expressions on each call. Instead move the compilation into the factory function.
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanitizeShop() recompiled multiple complex regular expressions on each call. Instead move the compilation into the factory function.
WHY are these changes introduced?
Don't recompile multiple complex regular expressions on every request.
WHAT is this pull request doing?
Move the compilation into the factory function.
Type of change
Checklist
pnpm changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)