Fix Loop Node Creation Reactivity and Audit Architecture#173
Conversation
- Fix reactivity bug in ActionZone.vue by replacing array splice with atomic map/spread reassignments. - Ensure ActionZone internal state resets after successful node creation. - Decouple components from the unified useStore facade to ensure direct interaction with Pinia stores (graph, UI, rule). - Fix broken edge reassignment in App.vue and ActionZone.vue. - Perform audit of manual and automatic node creation paths.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fix reactivity bug in ActionZone.vue by replacing array splice with atomic map/spread reassignments. - Ensure ActionZone internal state resets after successful node creation. - Decouple components from the unified useStore facade to ensure direct interaction with Pinia stores (graph, UI, rule). - Fix broken edge reassignment in App.vue and ActionZone.vue. - Perform audit of manual and automatic node creation paths. - Apply prettier formatting fixes across the codebase to pass CI linters.
|
This is new task todo |
1 participant
Fixed a critical bug in the Rule Builder where creating an action node within a Loop (the Loop Body selector) would fail to update the UI and leave the creation controls visible.
The issue was traced to the use of
Array.prototype.spliceon a non-reactive spread of the Pinia store, which Vue 3 and Vue Flow failed to detect as a structural update.Refactored the core builder components to use atomic array reassignments and direct store hooks (
useGraphStore,useUIStore,useRuleStore) instead of the legacyuseStorefacade. This ensures robust reactivity across all node and edge mutations.PR created automatically by Jules for task 17423668716432619132 started by @Sendipad