Repository navigation
Allow for the CPU-dependent GMRES reference in the dense LU NaN test - #333
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"a small dense LU fails a ksponly solve on NaN as an exact Krylov solve does" compares the small dense LU solve with a GMRES+ILU reference at rtol 1e-10. The dense LU result is the same bit for bit on every runner, but the reference moves with the CPU's OpenBLAS kernel: its relative difference from the LU result is 4.7e-13 on an EPYC 7763, 5.9e-11 on a Xeon 8370C or EPYC 9V74, and 1.25e-10 on a Xeon Platinum 8573C, where the test fails. Main fails it too whenever x64 Core 1/2 lands on that CPU (it did on two branches this week with identical values), so this loosens that one comparison to rtol 1e-9. The step counts and retcodes it also checks are unchanged.
All jobs pass on the fork: https://github.com/singhharsh1708/PETScDiffEq.jl/actions/runs/41298814917