Repository navigation
Use the own keyword of VecPtr on PETSc.jl 0.5.4 - #330
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main started failing on the Julia 1 jobs after PETSc.jl 0.5.4 was released. The last passing run resolved PETSc v0.5.3 and the failing run resolved v0.5.4, with PETSc_jll at 3.25.4 in both. PETSc.jl 0.5.4 makes
owna keyword ofVecPtr, and the positional form now emits a one-time deprecation warning. This package calledPETSc.VecPtr(pl, ptr, false)in 25 places, so that warning shows up in every test that captures logs or counts warnings. The Julia 1.10 jobs resolve PETSc 0.4.14 and were not affected. The same failures reproduce on Julia 1.12.7 with PETSc 0.5.4, so the Julia version is not the cause.This adds
PETScCompat.VecPtr(pl, ptr), which uses the keyword on PETSc 0.5.4 and later and the positional form on earlier versions, where the keyword does not exist. All 25 call sites use it. No other function deprecated in 0.5.4 is called from src or ext. The version is bumped to 0.14.1.The five affected top-level testsets pass (1195/1195) on Julia 1.12.7 with PETSc 0.5.4 and on Julia 1.10.12 with PETSc 0.4.14, and the MPI group passes on 2 ranks locally. All 17 jobs pass on the fork CI: https://github.com/singhharsh1708/PETScDiffEq.jl/actions/runs/40454910703
AI Disclosure: Claude assisted with the code. Testing and review by @singhharsh1708.