Repository navigation
[STORY-2698] feat(db-ng): Use new DatabaseNG from go-scalingo - #1164
Conversation
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0 |
matthieu526-scalingo
left a comment
There was a problem hiding this comment.
I know this PR is not ready to be merged yet, as the SDK is not released. Nonethess, something weird happened. You updated a vendor file without impacting the go.mod.
What you can do to open a PR that is "clean" even if not definitive.
go get -u github.com/Scalingo/go-scalingo/v8@feat/db-ng/use-database-object-from-api
go mod tidy
go mod vendorI think that would work 🙂
curzolapierre
left a comment
There was a problem hiding this comment.
Could you add an example in the PR's description please?
|
Did a last QA session:
db seems empty but the db is created
|
All is fixed, tested also the |
Related to [STORY-2698]
Depends on Scalingo/go-scalingo#441
This PR remove the usage of App and Addon returned from api database endpoint. The
DatabaseNGtype has been updated. There is no new featureHow to use:
database-create --type postgresql-ng --plan postgresql-ng-starter-1024 my-new-db-ngwill create a new postgresql-ng-starter-1024 DBNG namedmy-new-db-ng