Skip to content

[STORY-2698] feat(db-ng): Use new DatabaseNG from go-scalingo - #1164

Merged
baptmaury merged 11 commits into
masterfrom
feat/db-ng/use-go-scalingo-new-databases_preview
Dec 15, 2025
Merged

baptmaury merged 11 commits into
masterfrom
feat/db-ng/use-go-scalingo-new-databases_preview

Conversation

@baptmaury

@baptmaury baptmaury commented Dec 2, 2025 •

Copy link
Copy Markdown
Contributor

Related to [STORY-2698]

Depends on Scalingo/go-scalingo#441

This PR remove the usage of App and Addon returned from api database endpoint. The DatabaseNG type has been updated. There is no new feature

How to use:

database-create --type postgresql-ng --plan postgresql-ng-starter-1024 my-new-db-ng will create a new postgresql-ng-starter-1024 DBNG named my-new-db-ng

@semgrep-code-scalingo

Copy link
Copy Markdown

Legal Risk

The following dependencies were released under a license that
has been flagged by your organization for consideration.

Recommendation

While merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue.

MPL-2.0

@baptmaury baptmaury changed the title Use new databases_preview from go-scalingo feat(db-ng): Use new databaseNg from go-scalingo Dec 2, 2025
@baptmaury baptmaury changed the title feat(db-ng): Use new databaseNg from go-scalingo [STORY-2698] feat(db-ng): Use new databaseNg from go-scalingo Dec 2, 2025
@notion-workspace

Copy link
Copy Markdown

@baptmaury
baptmaury marked this pull request as ready for review December 2, 2025 15:53
@baptmaury baptmaury changed the title [STORY-2698] feat(db-ng): Use new databaseNg from go-scalingo [STORY-2698] feat(db-ng): Use new DatabaseNG from go-scalingo Dec 2, 2025

@matthieu526-scalingo matthieu526-scalingo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR is not ready to be merged yet, as the SDK is not released. Nonethess, something weird happened. You updated a vendor file without impacting the go.mod.
What you can do to open a PR that is "clean" even if not definitive.

go get -u github.com/Scalingo/go-scalingo/v8@feat/db-ng/use-database-object-from-api
go mod tidy
go mod vendor

I think that would work 🙂

@curzolapierre curzolapierre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an example in the PR's description please?

Comment thread dbng/info.go
@baptmaury
baptmaury requested a review from a team as a code owner December 12, 2025 16:27
@baptmaury
baptmaury requested review from briceamen and removed request for a team December 12, 2025 16:27
@baptmaury

Copy link
Copy Markdown
Contributor Author

Did a last QA session:

  • databases : ok
  • database-info : ok
  • database-create : there is an issue with the response message: -----> Your database ('') is being provisioned…
io.Statusf("Your %s database %s ('%s') is being provisioned…\n\n",
	db.Technology,
	db.ID,
	db.Name,
)

db seems empty but the db is created

  • database-delete : ok

@baptmaury

Copy link
Copy Markdown
Contributor Author

Did a last QA session:

* databases : ok

* database-info : ok

* database-create : there is an issue with the response message: `-----> Your  database  ('') is being provisioned…`
io.Statusf("Your %s database %s ('%s') is being provisioned…\n\n",
	db.Technology,
	db.ID,
	db.Name,
)

db seems empty but the db is created

* database-delete : ok

All is fixed, tested also the --wait arg, work as expected

@baptmaury
baptmaury merged commit 6729cbf into master Dec 15, 2025
7 checks passed
@baptmaury
baptmaury deleted the feat/db-ng/use-go-scalingo-new-databases_preview branch December 15, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants