Skip to content

fix(privatenetworks): default format should be table - #1154

Merged
EtienneM merged 1 commit into
masterfrom
fix/STORY-2436/default_format_table
Oct 6, 2025
Merged

EtienneM merged 1 commit into
masterfrom
fix/STORY-2436/default_format_table

Conversation

@EtienneM

@EtienneM EtienneM commented Oct 6, 2025 •

Copy link
Copy Markdown
Member

table is the default format in all the CLI. I think it should still be the same.

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM self-assigned this Oct 6, 2025
@notion-workspace

Copy link
Copy Markdown

@EtienneM
EtienneM force-pushed the fix/STORY-2436/default_format_table branch from a541e54 to 9906855 Compare October 6, 2025 07:17
@EtienneM
EtienneM marked this pull request as ready for review October 6, 2025 07:17
@EtienneM
EtienneM requested a review from sc-zenokerr October 6, 2025 07:19
@EtienneM
EtienneM enabled auto-merge October 6, 2025 07:19

@sc-zenokerr sc-zenokerr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread cmd/privatenetworks.go
&cli.StringFlag{
Name: "format",
Value: "json",
Value: outputFormatTable,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for using one of the consts here.

@EtienneM
EtienneM merged commit 1fed6ef into master Oct 6, 2025
8 checks passed
@EtienneM
EtienneM deleted the fix/STORY-2436/default_format_table branch October 6, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants