Skip to content

Update the unschedule message wording #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminach merged 3 commits into from
Sep 11, 2025
Merged

Update the unschedule message wording #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0ea98f
Update the unschedule message to use wording similar to the one on th…
benjaminach Sep 1, 2025
0189120
Update cmd/databases.go
benjaminach Sep 5, 2025
d276dfc
Add the changelog entry for the upcoming version.
benjaminach Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## To Be Released

* task(backups-config): update error message when unscheduling periodic backup
* feat(backups): prevent download of OpenSearch and Elasticsearch backups

### 1.38.0
Expand Down
4 changes: 2 additions & 2 deletions cmd/databases.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ var (
}

if disable {
continueB := askContinue("This operation will disable the periodic backups of a database. Are you sure?")
continueB := askContinue("Disabling periodic backups will prevent Scalingo from restoring your database in case of data loss or corruption. Backups are a critical safeguard, and we strongly recommend keeping them enabled. Do you want to continue? (yes/no)")
if !continueB {
errorQuit(ctx, errors.New("unschedule operation was not confirmed"))
errorQuit(ctx, errors.New("periodic backups are still enabled"))
return nil
}

Expand Down