Stop reporting Aviation Weather outages as app defects

[RISCfuture]

Two Sentry issues were Aviation Weather failing on its own end, reported as though this app had a defect:

• SF50-TOLD-2F — gzip decompression failure with dataSize: 0 on https://aviationweather.gov/data/cache/tafs.cache.xml.gz. The server serves an empty cache file while regenerating it, so the app tried to gunzip nothing.
• SF50-TOLD-2G — the same shape, an HTTP 502 from the CDN on the winds-aloft endpoint.

Neither is a defect here, yet both reached Sentry as warnings.

Design

An upstream 500 is not automatically retryable. That the AWC answers one at all is a flaw on their end, and working around a third party's flawed behavior with a backoff loop is not this app's job. So the app reports nothing to Sentry for third-party failures and leaves the retry decision to the pilot.

Changes

• Reject an empty body at the fetch site as Errors.emptyResponse rather than letting it reach the decompressor, so "the server sent nothing" stays distinguishable from "the body arrived corrupt". A corrupt non-empty body is still reported — that would be a real contract break.
• Add isUpstreamServerFailure (5xx and empty bodies) and fold it together with the existing cancellation and URLError sets into shouldReport, the single gate all three feeds and WeatherViewModel's conditions stream now consult. The conditions stream re-reports whatever the loader surfaces, so widening only the loader would have left the duplicate report that Stop reporting transient weather-fetch network errors to Sentry #9 fixed for URLErrors.
• Collapse the three duplicated catch-block classifications into recordLoadFailure, preserving the existing Sentry tags and fingerprints so grouping is unaffected.

The pilot's recourse needed no new code

The manual retry affordance already exists and is reachable in the error state, so no UI was added:

• TakeoffAirportView / LandingAirportView keep the weather row as a NavigationLink into WeatherPicker even when weather failed (the row reads "Couldn't load weather — using ISA").
• WeatherPicker renders WeatherSource whenever it is not actively loading, which is the case in the error state.
• WeatherSource titles its button "Try Again" whenever error != nil, calling load(force: true), which bypasses the 15 minute reload interval and re-runs all three feeds.
• The picker's "Customize Weather" form is right below it.

That makes the existing recoverySuggestion — "Try re-downloading weather data later, or manually enter weather." — actually true.

Verified live on an iOS 26 simulator via the WEATHER-ERROR launch argument: the Weather picker's Source section reads "Couldn't load weather — using ISA" with a Try Again button beside it, above the Customize Weather form.

On testing

shouldReport is left untested. It is internal and only observable through Sentry, so pinning it would mean reaching through @testable — the white-box shape rejected in review in ef1fe35 ("unit tests should be black box"). The classification itself is a switch over status-code ranges, which the repo's rule against trivial tests also covers. No UI test was added either: the retry control is pre-existing and a single button is not a major user flow.

Verification

• swift format lint --strict and swiftlint --strict clean on all changed files (only the pre-existing switch_case_alignment config warning).
• SF50 TOLD scheme builds for iOS 26 (iPhone 17 Pro), isolated derivedDataPath.
• SF50 Shared Unit Tests test plan (the one CI runs): 304/304 pass, 0 failures, read via xcresultparser.

Fixes SF50-TOLD-2F
Fixes SF50-TOLD-2G

🤖 Generated with Claude Code