Skip to content

chore: Separate api-docs PR and trigger another workflow for it#1718

Merged
marikaner merged 49 commits into
mainfrom
chore-separate-docs-prs
May 7, 2026
Merged

chore: Separate api-docs PR and trigger another workflow for it#1718
marikaner merged 49 commits into
mainfrom
chore-separate-docs-prs

Conversation

@emincihangeri

Copy link
Copy Markdown
Contributor

Context

Closes SAP/ai-sdk-js-backlog#453.

What this PR does and why it is needed

@hyperspace-insights

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Separate API Docs PR from Release Notes Workflow

Refactor

♻️ Decoupled the API documentation generation from the release notes workflow. Previously, API docs and release notes were bundled into a single PR during the release bump. They are now handled as two separate, independent PRs — improving modularity and allowing each to be triggered and merged independently.

Changes

  • .github/workflows/api-docs.yml: Refactored into a reusable workflow supporting both workflow_call (triggered from bump.yml) and workflow_dispatch (manual trigger). Replaced SSH-based git cloning with actions/checkout, switched to GH_CLOUD_SDK_JS_ADMIN_WRITE_TOKEN for authentication, and streamlined the steps for copying docs, creating a branch, and opening a dedicated API docs PR in the SAP/ai-sdk repository.

  • .github/workflows/bump.yml: Split the former prepare-release-notes-and-docs job into two separate jobs:

    • prepare-release-notes: Now only handles release notes (removes API doc generation and copying steps).
    • generate-api-docs: New job that calls the reusable api-docs.yml workflow after the bump, passing the version as input.
  • .github/workflows/publish-release.yml: Renamed check-docs-prcheck-release-notes-pr and merge-docs-prmerge-release-notes-pr, along with all associated output variable and step name references, to reflect that this workflow now exclusively manages the release notes PR lifecycle.


  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.20.0 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback


💌 Have ideas or want to contribute? Create an issue and share your thoughts with us!
📑 Check out the documentation for more information.
📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

Made with ❤️ by Hyperspace.

@emincihangeri emincihangeri changed the title chore: Seperate api-docs PR and trigger another workflow for it chore: Separate api-docs PR and trigger another workflow for it Apr 7, 2026
@emincihangeri emincihangeri requested a review from marikaner April 7, 2026 12:17
Comment thread .github/workflows/api-docs.yml Outdated
Comment thread .github/workflows/api-docs.yml Outdated
Comment thread .github/workflows/api-docs.yml Outdated
Comment thread .github/workflows/bump.yml Outdated
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
Comment thread .github/workflows/api-docs.yml Outdated

@marikaner marikaner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the non-existent token + env variable, everything else is details, but would be nice to have before merging.

Comment thread .github/workflows/api-docs.yml Outdated
Comment thread .github/workflows/publish-release.yml Outdated
Comment thread .github/workflows/publish-release.yml Outdated
Comment thread .github/workflows/publish-release.yml Outdated
Comment thread .github/workflows/publish-release.yml Outdated
Comment thread .github/workflows/bump.yml Outdated
Comment thread .github/workflows/bump.yml Outdated
Comment thread .github/workflows/api-docs.yml Outdated
Comment thread .github/workflows/bump.yml Outdated

@marikaner marikaner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thought: I think it would be even better, if you made a reusable create-api-docs-pr action. Then you could use that directly in the api-docs.yml and bump.yml

emincihangeri and others added 2 commits April 23, 2026 13:32
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
@emincihangeri

Copy link
Copy Markdown
Contributor Author

one more thought: I think it would be even better, if you made a reusable create-api-docs-pr action. Then you could use that directly in the api-docs.yml and bump.yml

So the bump workflow calling the api-docs.yml will no longer be the logic? but we still want to have the api-docs.yml for manual triggering then, right?

@marikaner marikaner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have some requests. I think it was not necessary to move the api-docs implementation to an action (my bad) but it is a good idea, if we want to align this between Cloud SDK and AI SDK, so let's keep it as is.

Comment thread .github/actions/create-api-docs-pr/action.yml Outdated
Comment thread .github/actions/create-api-docs-pr/action.yml Outdated
Comment thread .github/actions/create-api-docs-pr/action.yml Outdated
Comment thread .github/actions/create-api-docs-pr/action.yml Outdated
Comment thread .github/workflows/bump.yml Outdated
Comment thread .github/workflows/bump.yml Outdated

@davidkna-sap davidkna-sap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions (also to pre-emptively reduce conflicts with #1822), please have a look - otherwise lgtm.

Comment thread .github/actions/create-api-docs-pr/action.yml
Comment thread .github/actions/create-api-docs-pr/action.yml Outdated
Comment thread .github/workflows/publish-release.yml Outdated
Comment thread .github/workflows/publish-release.yml Outdated
Comment thread .github/workflows/bump.yml Outdated

@marikaner marikaner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for putting that much effort into this 😊

@marikaner marikaner merged commit 7898a5a into main May 7, 2026
14 checks passed
@marikaner marikaner deleted the chore-separate-docs-prs branch May 7, 2026 08:08
davidkna-sap added a commit that referenced this pull request May 7, 2026
* origin/main:
  chore(deps-dev): Bump typescript from 5.9.3 to 6.0.3 (#1828)
  chore: Configure `save-exact` for smoke test package (#1774)
  chore(type-tests): Replace context-incorrect jest `expect` with `tsd` `expectAssignable` (#1801)
  chore: Separate api-docs PR and trigger another workflow for it (#1718)
  chore: Use new pnpm-based license checker (#1728)
  chore(deps): Bump SonarSource/sonarqube-scan-action from 6.0.0 to 8.0.0 (#1827)
  chore(deps): Bump slackapi/slack-github-action from 3.0.2 to 3.0.3 (#1826)
  chore(sample): Refactor geocoding and forecast URL construction (#1824)
  fix: Check for isTemplateRef and append messages to messages_history (#1798)
  chore(deps): Bump zod from 4.4.1 to 4.4.2 (#1829)
  chore(deps): Bump github/codeql-action from 4.35.2 to 4.35.3 (#1825)
davidkna-sap added a commit that referenced this pull request May 7, 2026
* origin/main: (25 commits)
  chore: Disable dependabot for v1 (#1832)
  chore: Fix lockfile (#1833)
  chore: Update available model list (#1830)
  chore(ci): Improve sonar coverage configuration (#1806)
  chore: Integrate Prettier for formatting in sync-model-types script (#1802)
  chore(deps-dev): Bump typescript from 5.9.3 to 6.0.3 (#1828)
  chore: Configure `save-exact` for smoke test package (#1774)
  chore(type-tests): Replace context-incorrect jest `expect` with `tsd` `expectAssignable` (#1801)
  chore: Separate api-docs PR and trigger another workflow for it (#1718)
  chore: Use new pnpm-based license checker (#1728)
  chore(deps): Bump SonarSource/sonarqube-scan-action from 6.0.0 to 8.0.0 (#1827)
  chore(deps): Bump slackapi/slack-github-action from 3.0.2 to 3.0.3 (#1826)
  chore(sample): Refactor geocoding and forecast URL construction (#1824)
  fix: Check for isTemplateRef and append messages to messages_history (#1798)
  chore(deps): Bump zod from 4.4.1 to 4.4.2 (#1829)
  chore(deps): Bump github/codeql-action from 4.35.2 to 4.35.3 (#1825)
  chore: update pnpm transitive dependencies (#1809)
  chore: Fix smoke test (#1816)
  chore(deps): Bump zod from 4.4.0 to 4.4.1 (#1820)
  chore(deps): Bump hono from 4.12.15 to 4.12.16 (#1819)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants