chore: Separate api-docs PR and trigger another workflow for it#1718
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: Separate API Docs PR from Release Notes WorkflowRefactor♻️ Decoupled the API documentation generation from the release notes workflow. Previously, API docs and release notes were bundled into a single PR during the release bump. They are now handled as two separate, independent PRs — improving modularity and allowing each to be triggered and merged independently. Changes
PR Bot InformationVersion:
💌 Have ideas or want to contribute? Create an issue and share your thoughts with us! Made with ❤️ by Hyperspace. |
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
marikaner
left a comment
There was a problem hiding this comment.
We should remove the non-existent token + env variable, everything else is details, but would be nice to have before merging.
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
This reverts commit 4a92f92.
marikaner
left a comment
There was a problem hiding this comment.
one more thought: I think it would be even better, if you made a reusable create-api-docs-pr action. Then you could use that directly in the api-docs.yml and bump.yml
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
So the bump workflow calling the api-docs.yml will no longer be the logic? but we still want to have the api-docs.yml for manual triggering then, right? |
marikaner
left a comment
There was a problem hiding this comment.
I still have some requests. I think it was not necessary to move the api-docs implementation to an action (my bad) but it is a good idea, if we want to align this between Cloud SDK and AI SDK, so let's keep it as is.
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
Co-authored-by: Marika Marszalkowski <marika.marszalkowski@sap.com>
There was a problem hiding this comment.
I've made some suggestions (also to pre-emptively reduce conflicts with #1822), please have a look - otherwise lgtm.
Co-authored-by: David Knaack <david.knaack@sap.com>
Co-authored-by: David Knaack <david.knaack@sap.com>
Co-authored-by: David Knaack <david.knaack@sap.com>
marikaner
left a comment
There was a problem hiding this comment.
LGTM. Thanks for putting that much effort into this 😊
* origin/main: chore(deps-dev): Bump typescript from 5.9.3 to 6.0.3 (#1828) chore: Configure `save-exact` for smoke test package (#1774) chore(type-tests): Replace context-incorrect jest `expect` with `tsd` `expectAssignable` (#1801) chore: Separate api-docs PR and trigger another workflow for it (#1718) chore: Use new pnpm-based license checker (#1728) chore(deps): Bump SonarSource/sonarqube-scan-action from 6.0.0 to 8.0.0 (#1827) chore(deps): Bump slackapi/slack-github-action from 3.0.2 to 3.0.3 (#1826) chore(sample): Refactor geocoding and forecast URL construction (#1824) fix: Check for isTemplateRef and append messages to messages_history (#1798) chore(deps): Bump zod from 4.4.1 to 4.4.2 (#1829) chore(deps): Bump github/codeql-action from 4.35.2 to 4.35.3 (#1825)
* origin/main: (25 commits) chore: Disable dependabot for v1 (#1832) chore: Fix lockfile (#1833) chore: Update available model list (#1830) chore(ci): Improve sonar coverage configuration (#1806) chore: Integrate Prettier for formatting in sync-model-types script (#1802) chore(deps-dev): Bump typescript from 5.9.3 to 6.0.3 (#1828) chore: Configure `save-exact` for smoke test package (#1774) chore(type-tests): Replace context-incorrect jest `expect` with `tsd` `expectAssignable` (#1801) chore: Separate api-docs PR and trigger another workflow for it (#1718) chore: Use new pnpm-based license checker (#1728) chore(deps): Bump SonarSource/sonarqube-scan-action from 6.0.0 to 8.0.0 (#1827) chore(deps): Bump slackapi/slack-github-action from 3.0.2 to 3.0.3 (#1826) chore(sample): Refactor geocoding and forecast URL construction (#1824) fix: Check for isTemplateRef and append messages to messages_history (#1798) chore(deps): Bump zod from 4.4.1 to 4.4.2 (#1829) chore(deps): Bump github/codeql-action from 4.35.2 to 4.35.3 (#1825) chore: update pnpm transitive dependencies (#1809) chore: Fix smoke test (#1816) chore(deps): Bump zod from 4.4.0 to 4.4.1 (#1820) chore(deps): Bump hono from 4.12.15 to 4.12.16 (#1819) ...
Context
Closes SAP/ai-sdk-js-backlog#453.
What this PR does and why it is needed