-
-
Notifications
You must be signed in to change notification settings - Fork 48
Centralize Emscripten (and other) version configurations #611
Copy link
Copy link
Open
Labels
build-systemdev-experiencedifficulty: easySingle file, main build path, fix described in the issue. Verifiable in minutes.Single file, main build path, fix described in the issue. Verifiable in minutes.enhancementNew feature or requestNew feature or requesttakenThis item has been claimedThis item has been claimed
Description
Activity
Metadata
Metadata
Assignees
Labels
build-systemdev-experiencedifficulty: easySingle file, main build path, fix described in the issue. Verifiable in minutes.Single file, main build path, fix described in the issue. Verifiable in minutes.enhancementNew feature or requestNew feature or requesttakenThis item has been claimedThis item has been claimed
Projects
- StatusShow more project fieldsIn progress
Caution
This issue has been claimed by @vedantp404, so it is not recommended that you work on it.
Problem
The Emscripten version is currently defined in the development Docker image (after #604 merges):
ENV EMSDK_VERSION=6.0.9However, GitHub Actions also needs to specify an Emscripten version when using setup-emsdk (see release.yml, if it shows no specific version, that means
latest).This creates two independent sources of truth for the same toolchain version. Whenever Emscripten is upgraded, multiple files must be updated, increasing the risk that local development, Docker builds, and CI use different versions.
Solution
Introduce a single source of truth for the Emscripten and other future dependency versions.
For example, a folder called
.versionswith a file called.emscripten.jsonwhich contains the6.0.9version definition. JSON is extensible, so future refactors and updates will likely be far simpler.Then:
Benefits
Acceptance Criteria
Note
If scripting is necessary, please use either Python or JavaScript and place the code in the
scriptsfolder.