Repository navigation
Add Criterion benchmarks for public scraping APIs - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a separate Criterion 0.8.2 suite for request building/cloning, UTF-8 and Windows-1252 decoding, fresh and warm CSS selection, optional compiled/string XPath, invalid CSS, and relative URL following. Deterministic bounded fixtures and correctness assertions outside timing cover 23 default workloads and 29 with XPath. Existing custom harnesses and library behavior are preserved.
Documents timing boundaries, feature-dependent DOM caching, XML-compatible XPath fixtures, and reproducible baseline comparisons. Criterion's minimum Rust version (1.86) is below the project's 1.92 MSRV; existing dependency versions are preserved.
Validation:
The GitHub commit reproduces the exact source tree of local commit d9d8436; its SHA differs because it was published through the GitHub connector. Generated reports and build artifacts are excluded.