Recatoring to improve nullable and readability of DataProtectedIdentityServerKeyMaterialConverter - #53
Open
equist wants to merge 4 commits into
Open
Recatoring to improve nullable and readability of DataProtectedIdentityServerKeyMaterialConverter #53equist wants to merge 4 commits into
equist wants to merge 4 commits into
Conversation
…more readable and parts of it more re-usable.
equist
changed the title
Contributor
Author
|
I'll start doing seperate branches in the future even for the small changes to avoid that a pull request get changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small nullable improvments of string extensions. I have not created any issue for this.
Small re-factoring of DataProtectedIdentityServerKeyMaterialConverter to make it more readable and parts of it more re-usable.
Type of change
Does this PR introduce a breaking change?
Does the change cause existing functionality to not work as previously expected, or does the DB schema or C# public API surface change?
LLM Usage
Co-pilot used to generate test data suggestions for unit tests.