Fix: clear the discrete observation-buffer slot when an emitter is unsubscribed - #83
Open
docxology wants to merge 1 commit into
Open
Conversation
When a discrete receiver unsubscribes an emitter, the emitter's per-source observation buffer slot was left behind. The discrete forwarder only emits an ObservationCollection once every buffered source has contributed, so the stale empty slot permanently blocked all further observations to surviving agents. Drop the emitter's buffer slot on unsubscribe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
Rocket.unsubscribe!(emitter, receiver)severs an emitter from a discrete receiver, the receiver'sObservations.bufferstill holds the emitter's slot (nothingafter a clear, or a staleObservation). Thediscrete forwarder (
src/markovblanket.jl:73-80) requires all buffer slots to be filled before emitting, sothe removed emitter's dead slot blocks all future observations — the environment silently stops emitting to the
surviving agents.
Change
src/abstractentity.jl— inRocket.unsubscribe!(emitter::AbstractEntity, receiver::AbstractEntity), when thereceiver is discrete, delete the emitter from the receiver's observation buffer:
How to verify
Add/run the discrete unsubscribe regression:
Run
julia --project=. -e 'using Pkg; Pkg.test()'— discrete entity tests remain green.Notes
The continuous path is unaffected. This is a focused one-line-class fix; a follow-up could also add a
clear_buffer!-style reset on unsubscribe for robustness.