fix(navbar): preserve locale behind base path - #158
Open
morluto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getUserLanguage()reads the first URL segment as the locale. On GitHub Pages, the first segment is the deployment base path (qwen-code-docs), so navbar links can fall back to the browser language instead of preserving the locale in the current route.For example, a visitor on
/qwen-code-docs/fr/...can receive English navbar destinations when their browser language is English.Changes
Validation
cd website && npm testcd website && npx tsc --noEmit --incremental falseorigin/main: cleanBuild note
npm run buildreaches Next.js compilation but currently fails onpublic/fonts/JetBrainsMono/JetBrainsMono-Variable.ttfwithUnknown font format. That asset failure is present outside this navbar change and is not included here.