Skip to content

fix(i18n): clarify Go regex and field passthrough copy#6183

Open
seefs001 wants to merge 1 commit into
QuantumNous:mainfrom
seefs001:fix/i18n
Open

fix(i18n): clarify Go regex and field passthrough copy#6183
seefs001 wants to merge 1 commit into
QuantumNous:mainfrom
seefs001:fix/i18n

Conversation

@seefs001

@seefs001 seefs001 commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

⚠️ 提交说明 / PR Notice

Important

  • 请提供人工撰写的简洁摘要,避免直接粘贴未经整理的 AI 输出。

📝 变更描述 / Description

(简述:做了什么?为什么这样改能生效?请基于你对代码逻辑的理解来写,避免粘贴未经整理的内容)

🚀 变更类型 / Type of change

  • 🐛 Bug 修复 (Bug fix) - 请关联对应 Issue,避免将设计取舍、理解偏差或预期不一致直接归类为 bug
  • ✨ 新功能 (New feature) - 重大特性建议先通过 Issue 沟通
  • ⚡ 性能优化 / 重构 (Refactor)
  • 📝 文档更新 (Documentation)

🔗 关联任务 / Related Issue

  • Closes # (如有)

✅ 提交前检查项 / Checklist

  • 人工确认: 我已亲自整理并撰写此描述,没有直接粘贴未经处理的 AI 输出。
  • 非重复提交: 我已搜索现有的 IssuesPRs,确认不是重复提交。
  • Bug fix 说明: 若此 PR 标记为 Bug fix,我已提交或关联对应 Issue,且不会将设计取舍、预期不一致或理解偏差直接归类为 bug。
  • 变更理解: 我已理解这些更改的工作原理及可能影响。
  • 范围聚焦: 本 PR 未包含任何与当前任务无关的代码改动。
  • 本地验证: 已在本地运行并通过测试或手动验证,维护者可以据此复核结果。
  • 安全合规: 代码中无敏感凭据,且符合项目代码规范。

📸 运行证明 / Proof of Work

(请在此粘贴截图、关键日志或测试报告,以证明变更生效)

Summary by CodeRabbit

  • UI Improvements
    • Clarified that model, path, value, and replacement patterns use Go regular expressions (RE2 syntax).
    • Updated labels, validation messages, and help text to explain syntax restrictions and comma-handling guidance.
    • Improved passthrough and blocking settings with clearer, field-specific descriptions.
    • Updated translations across supported languages to reflect the revised terminology and guidance.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a394488-c4ba-4277-a29a-62c7a625cc77

📥 Commits

Reviewing files that changed from the base of the PR and between 7c28993 and d63d797.

📒 Files selected for processing (15)
  • web/default/src/features/channels/components/dialogs/advanced-custom-editor-dialog.tsx
  • web/default/src/features/channels/components/dialogs/param-override-editor-dialog.tsx
  • web/default/src/features/channels/components/drawers/channel-mutate-drawer.tsx
  • web/default/src/features/channels/lib/advanced-custom.ts
  • web/default/src/features/system-settings/general/channel-affinity/index.tsx
  • web/default/src/features/system-settings/general/channel-affinity/rule-editor-dialog.tsx
  • web/default/src/features/usage-logs/lib/format.ts
  • web/default/src/i18n/locales/en.json
  • web/default/src/i18n/locales/fr.json
  • web/default/src/i18n/locales/ja.json
  • web/default/src/i18n/locales/ru.json
  • web/default/src/i18n/locales/vi.json
  • web/default/src/i18n/locales/zh-TW.json
  • web/default/src/i18n/locales/zh.json
  • web/default/src/i18n/static-keys.ts
👮 Files not reviewed due to content moderation or server errors (7)
  • web/default/src/i18n/locales/en.json
  • web/default/src/i18n/locales/fr.json
  • web/default/src/i18n/locales/ja.json
  • web/default/src/i18n/locales/ru.json
  • web/default/src/i18n/locales/vi.json
  • web/default/src/i18n/locales/zh-TW.json
  • web/default/src/i18n/locales/zh.json

Walkthrough

The PR standardizes regular-expression UI copy around Go/RE2 syntax, updates passthrough controls to use parameterized translations, revises model-matching validation and affinity labels, and synchronizes these changes across supported locales.

Changes

Go regex terminology

Layer / File(s) Summary
Regex controls and action labels
web/default/src/features/channels/components/dialogs/advanced-custom-editor-dialog.tsx, web/default/src/features/channels/components/dialogs/param-override-editor-dialog.tsx, web/default/src/features/usage-logs/lib/format.ts, web/default/src/i18n/static-keys.ts
Regex badges, replacement modes, pattern labels, and action labels now explicitly use “Go Regex” terminology.
Passthrough controls
web/default/src/features/channels/components/drawers/channel-mutate-drawer.tsx
Advanced passthrough labels and descriptions use {{field}} translations, and model-list guidance specifies ASCII commas and RE2 constraints.
Validation and affinity labels
web/default/src/features/channels/lib/advanced-custom.ts, web/default/src/features/system-settings/general/channel-affinity/*
Validation messages and model/value regex labels now identify Go syntax.
Localized copy
web/default/src/i18n/locales/*
Translations update Go/RE2 regex guidance, comma handling, replacement text, and generic passthrough placeholders across supported locales.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: calcium-ion, quentinhsu, feitianbubu

Poem

I’m a rabbit with regex in tow,
Hopping through labels that clearly say Go.
Fields bloom with names, commas behave,
RE2 guidance is tidy and brave.
“Passthrough!” I thump, then wiggle my nose—
The UI now speaks how the matcher code goes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: i18n copy updates for Go regex wording and field passthrough text.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant