Replace Nsymbol calls or add guards in fusion tree iteration - #515
Replace Nsymbol calls or add guards in fusion tree iteration#515borisdevos wants to merge 1 commit into
Nsymbol calls or add guards in fusion tree iteration#515Conversation
lkdvos
left a comment
There was a problem hiding this comment.
I do think this is probably quite a big performance hit right in the hot path of the fusiontree constructors though, I don't think there is typically a fast implementation of this. Additionally, I was kind of expecting to convert more things to Nsymbol, to actually make them error if the fusion is disallowed?
|
I'm misunderstanding then what kind of behavior we want. So we want |
|
I think that was what I was expecting, especially since we decided |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 42 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Deals with #514, at least partially.
Now we have
which behaves the same way as