Skip to content

fix gitversion to not recompute version from sdist #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hameerabbasi merged 3 commits into from
Feb 10, 2026
Merged

fix gitversion to not recompute version from sdist #316

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef7bf5
fix gitversion to not recompute version from sdist
lucascolley Feb 10, 2026
45a2b7c
Don't use `exec`.
hameerabbasi Feb 10, 2026
3074c3b
Update tools/gitversion.py
hameerabbasi Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions tools/gitversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,30 @@
#!/usr/bin/env python3

import importlib.util
import os
from pathlib import Path
import shutil

import versioningit


def main():
project_dir = Path(__file__).resolve().parents[1]
vig = versioningit.Versioningit.from_project_dir(project_dir)
print(vig.get_version(write=True, fallback=True))
source_version_path = project_dir / "src" / "uarray" / "_version.py"
if source_version_path.exists():
spec = importlib.util.spec_from_file_location(
"uarray._version",
source_version_path,
)
assert spec is not None
module = importlib.util.module_from_spec(spec)
assert spec.loader is not None
spec.loader.exec_module(module)
Comment thread
hameerabbasi marked this conversation as resolved.
Resolved
print(module.__version__)
else:
import versioningit
vig = versioningit.Versioningit.from_project_dir(project_dir)
print(vig.get_version(write=True, fallback=True))

if meson_dist_root := os.environ.get("MESON_DIST_ROOT"):
staged_version_path = Path(meson_dist_root) / "src" / "uarray" / "_version.py"
source_version_path = project_dir / "src" / "uarray" / "_version.py"
shutil.copy(source_version_path, staged_version_path)

if __name__ == "__main__":
Expand Down
Loading