Update MSVC compiler options for version 1.5.1 release#458
Closed
j2doll wants to merge 8 commits into
Closed
Conversation
- Disable strict MSVC compliance mode to prevent build errors caused by standard library ('stdext') changes in newer MSVC compilers with older Qt headers.
Replace MSVC compliance mode disabling with a definition to allow compiler and STL version mismatch.
Updated CMakeLists.txt to modify compiler options for MSVC.
Removed MSVC specific flags for permissive mode.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This pull request updates the QXlsx library to improve compatibility, especially with MSVC and different Qt versions, and bumps the library version. The main changes involve build system enhancements for compiler and Qt version handling, as well as a workaround for MSVC-specific iterator issues.
Build system and compatibility improvements:
CMakeLists.txtto reflect the new release.QXlsx.prito set the C++ standard based on the Qt version: C++11 for Qt 5, C++17 for Qt 6, with informative messages during configuration.QXlsx/header/xlsxglobal.hfor MSVC by providing a custommake_checked_array_iteratorto address compatibility issues.CMakeLists.txtto enforce the/permissiveflag for MSVC builds, ensuring standards compliance and preventing conflicts with/permissive-.Code cleanup:
mainwindow.cppand unnecessary source/header entries fromQXlsx.pro. [1] [2]