Repository navigation
Include the namespace in the HTML fragment cache key - #618
Open
Shaisolaris wants to merge 1 commit into
Open
Shaisolaris wants to merge 1 commit into
Shaisolaris wants to merge 1 commit into
Conversation
cachedParseHtmlWithContext keyed parsed fragments by tag name only, so an HTML element and an SVG or MathML element with the same name shared one parse. <title> and <style> parse their content as text in HTML but as markup inside <svg>, so whichever was seen first decided the result for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cachedParseHtmlWithContextkeys its cache onnodeName(context)(plus the form ancestor flag from #615), which drops the namespace. An HTML element and an SVG or MathML element with the same tag name therefore share one parse, and whichever is seen first decides the result for both.This shows up with
<title>and<style>, whose content is text in HTML but markup in foreign content:The fix adds
context.Namespaceto the cache key. Elements with the same name and namespace still share the cached parse.Related Issue
None that I found. This is the same cache as #586 and #615.
How Has This Been Tested?
TestAppendHtmlNamespaceContextandTestSetHtmlNamespaceContext. Both fail on master and pass with this change.go vet .andgo test .pass locally with Go 1.25.0. I did not run the CI matrix.