Repository navigation
Fix error code 87 when setting affinity. Add logging to Limit CPU Cores. - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling Limit CPU Cores by default has revealed an issue affecting a small number of players. If their machine (or Virtual Machine) has less then 4 Logical CPU Threads, Win32 throws error code 87 (Invalid Parameter) and crashes the game when setting the affinity.
This pull adds a few log lines to the Limit CPU Cores option and checks if there are more than 4 Logical CPU Threads before trying to clamp to 4. The Affinity log line should always return "15" when it works properly. This is correct since the 4 internally is a bitmask (00001111) and not an integer.