Repository navigation
Set a property's Display Attributes in the Layout editor - #1913
Draft
alistair3149 wants to merge 1 commit into
Draft
alistair3149 wants to merge 1 commit into
alistair3149 wants to merge 1 commit into
Conversation
alistair3149
force-pushed
the
alistair3149/display-attributes
branch
from
November 20, 2026 22:22
0496a08 to
ed515a5
Compare
A shown property whose Property Type has Display Attributes, today a Number's precision, opens a pane of its own in the Layout editor, from its row or by clicking it in the preview. An empty field takes the Schema's setting, and an icon button resets an override. The property list splits into Shown and Hidden groups on the shared editor row, and dragging a property from one group to the other shows or hides it. Extensions give a Property Type a `displayAttributesEditor`, which emits the attributes it changes. Number fields no longer step their value under the scroll wheel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alistair3149
force-pushed
the
alistair3149/display-attributes
branch
from
November 20, 2026 22:33
ed515a5 to
d6ba9da
Compare
Member
Author
layout-editor-display-attributes.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #693
A shown property whose Property Type has Display Attributes, today a Number's precision, opens a pane of its own in the Layout editor, from its row's chevron or by clicking it in the preview. An empty field takes the Schema's setting, and an icon button resets an override. The property list splits into Shown and Hidden groups on the shared editor row, and dragging a property from one group to the other shows or hides it. Extensions give a Property Type a
displayAttributesEditor, which emits the attributes it changes.Builds on #1887: merge that first.
Human input
Goal and shape: set by @alistair3149 and designed with Claude on a canvas; Claude made the technical design within it.
Outcome: design reviewed by @alistair3149 on canvas boards, one of them playable, and the built UI tried by @alistair3149 on the dev wiki; architecture and code not reviewed by a human. Left for you: the contract, the code.
Claude's calls
NeoNativeInput, so the Schema editor's number fields stop stepping under the wheel too;EditorListItemgains an always-visibleendslot and anunselectableflag.toFixedthrows), for a PR of its own.DisplayAttributesEditorContract.tsand the optionaldisplayAttributesEditor, both alpha public API (ADR 24).Release notes
In the Layout editor, set how a Layout shows a property, such as a number's precision.
Verification evidence
vue-tscand build pass;make ci5212 PHPUnit tests (10 skipped) and PHPStan;make browser-test13 passed./pr-review: code-review at max, security-review (nothing exploitable), review-tests (66 mutants, gaps filled), an escalated design pass, correctness and complexity second opinions, simplify. Its 8 blockers were fixed before this commit.