Repository navigation
Update index.js #4207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imazicristina-sketch
wants to merge
1
commit into
PrismarineJS:master
Choose a base branch
from
imazicristina-sketch:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update index.js #4207
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,12 @@ | ||
| if (typeof process !== 'undefined' && !process.browser && process.platform !== 'browser' && parseInt(process.versions.node.split('.')[0]) < 18) { | ||
| console.error('Your node version is currently', process.versions.node) | ||
| console.error('Please update it to a version >= 22.x.x from https://nodejs.org/') | ||
| process.exit(1) | ||
| } | ||
| const mineflayer = require('mineflayer') | ||
|
|
||
| module.exports = require('./lib/loader.js') | ||
| const bot = mineflayer.createBot({ | ||
| host: process.env.MC_SERVER_HOST, | ||
| port: Number(process.env.MC_SERVER_PORT || 25565), | ||
| username: 'FrostBot', | ||
| auth: 'offline' | ||
| }) | ||
|
|
||
| bot.on('login', () => console.log('Bot joined server!')) | ||
| bot.on('error', console.log) | ||
| bot.on('end', () => console.log('Bot disconnected')) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Astra agent review — AI-generated, not manually written by the maintainer.
[P1] Preserve the library entry point.
package.jsonstill declares this file asmain, but it now requiresmineflayerfrom inside Mineflayer and callscreateBotinstead of exporting./lib/loader.js. Normal installed consumers can hit a circular require with an incomplete export, and this file no longer supplies the documented API at all. Please keep the existing loader export; put a runnable FrostBot example underexamples/if that is the intended contribution.Skills used:
prismarine-architecture-review: traced the actual CommonJS entry point and separated reusable API initialization from application startup.