fix(daemon): anchor saved sibling validation - #1262
Closed
sethkarten wants to merge 8 commits into
Closed
Conversation
This was referenced Aug 11, 2026
sethkarten
marked this pull request as ready for review
August 12, 2026 06:00
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 514e155. Configure here.
sethkarten
force-pushed
the
core04-saved-sibling-validation
branch
from
August 12, 2026 18:34
8d77973 to
2b549ba
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Stack
core03-managed-session-catalog)Validation
Exclusions
Note
Medium Risk
Changes session naming and reservation for saved RLM siblings; malformed catalogs that previously slipped through are now rejected, which may block rename/create until data is fixed.
Overview
Saved passive sibling name checks in
DaemonSupervisornow resolve each child’sparentSessionPathagainst that session file (canonicalSavedSiblingParentPath), so siblings that point at the same parent via different relative paths share one reservation key and one parent anchor for Core03 name validation.assertSavedSiblingNameAvailablefails closed on ambiguous catalogs (duplicate ids/paths, mixed parents or depths, missing target) before callingassertAgentSessionNameAvailable. It synthesizes a local parent roster entry becausecatalog.siblings()only returns children, not the parent row.Create and rename paths route saved targets through
savedSiblingNameReservationInputinstead of raw persisted parent strings. Regression tests cover structural conflicts, relative parent equivalence, and in-flight reservation races.Reviewed by Cursor Bugbot for commit 1dd52db. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix saved sibling validation in
DaemonSupervisorto anchor parent paths canonicallycanonicalSavedSiblingParentPathto resolve relativeparentSessionPathvalues against each child session's file path, eliminating ambiguity from relative paths across siblings.assertSavedSiblingNameAvailablenow fails closed on structurally ambiguous catalogs (duplicate ids/paths, mismatched parent or depth, missing target) before performing name conflict checks.sessionNameReservationInputandcreateOrReuseWorkernow derive reservation inputs viasavedSiblingNameReservationInput, unifying reservations across siblings that reference the same parent via different relative paths.Macroscope summarized 1dd52db.