feat(Trucky): add activity - #11150
Open
gruposeguro2026-dev wants to merge 13 commits into
Open
Conversation
Signed-off-by: gruposeguro2026-dev <gruposeguro2026@gmail.com>
…tch-1 feat(Trucky): add presence
Updated Spanish comments and strings to English equivalents for better accessibility. Signed-off-by: gruposeguro2026-dev <gruposeguro2026@gmail.com>
…tch-2 feat(Trucky): add presence
Signed-off-by: gruposeguro2026-dev <gruposeguro2026@gmail.com>
…tch-3 Update metadata.json
Contributor
🖼️ Activity asset previewBehold, the gallery! Admission is free, but I do accept tips in the form of approvals. Trucky (
|
| Preview | Source | URL |
|---|---|---|
 |
logo | https://screen-mp.com/uploads/images/f138ec30-1dcc-4ac1-a320-56343d8ead64.png |
 |
thumbnail | https://screen-mp.com/uploads/images/6d3d76c8-aa58-4ae6-a30c-752395dee796.jpg |
Beep boop — I refresh this comment on every push, so no need to scroll. 🤖
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: gruposeguro2026-dev <gruposeguro2026@gmail.com>
Signed-off-by: gruposeguro2026-dev <gruposeguro2026@gmail.com>
Signed-off-by: gruposeguro2026-dev <gruposeguro2026@gmail.com>
Fix missing newline at end of file in presence.ts Signed-off-by: gruposeguro2026-dev <gruposeguro2026@gmail.com>
…tch-5 Add newline at end of presence.ts
Removed unused URLs and tags from metadata. Signed-off-by: gruposeguro2026-dev <gruposeguro2026@gmail.com>
…tch-6 Clean up metadata.json by removing URLs and tags
skullysmods
requested changes
Sep 4, 2026
| @@ -0,0 +1,58 @@ | |||
| { | |||
| "$schema": "https://schemas.premid.app/metadata/1.16", | |||
Member
There was a problem hiding this comment.
Suggested change
| "$schema": "https://schemas.premid.app/metadata/1.16", | |
| "$schema": "https://schemas.premid.app/metadata/1.17", |
| } | ||
|
|
||
| // Strategy 2: Find the element containing "Level " text | ||
| const allElements = Array.from(document.querySelectorAll('*')) |
Member
There was a problem hiding this comment.
Isn't there a more precise way than selecting the entire DOM?
It seems a bit messy and not very optimized.
| if (buttons) { | ||
| presenceData.buttons = [ | ||
| { label: 'View on TruckyMods', url: href }, | ||
| { label: 'Get Trucky', url: 'https://truckyapp.com/' }, |
Member
There was a problem hiding this comment.
Suggested change
| { label: 'Get Trucky', url: 'https://truckyapp.com/' }, |
Buttons for the home page are not allowed
| if (buttons) { | ||
| presenceData.buttons = [ | ||
| { label: 'View on VTC Hub', url: href }, | ||
| { label: 'Get Trucky', url: 'https://truckyapp.com/' }, |
Member
There was a problem hiding this comment.
Suggested change
| { label: 'Get Trucky', url: 'https://truckyapp.com/' }, |
ditto
| if (buttons) { | ||
| presenceData.buttons = [ | ||
| { label: 'Open Live Map', url: 'https://map.truckyapp.com/' }, | ||
| { label: 'Get Trucky', url: 'https://truckyapp.com/' }, |
Member
There was a problem hiding this comment.
Suggested change
| { label: 'Get Trucky', url: 'https://truckyapp.com/' }, |
ditto
| if (buttons) { | ||
| presenceData.buttons = [ | ||
| { label: 'Visit Page', url: href }, | ||
| { label: 'Get Trucky', url: 'https://truckyapp.com/' }, |
Member
There was a problem hiding this comment.
Suggested change
| { label: 'Get Trucky', url: 'https://truckyapp.com/' }, |
ditto
skullysmods
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected