Use FlushWriter to ensure traces are flushed#1556
Closed
SteveL-MSFT wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent trace-related CI failures (notably on macOS) by ensuring tracing output is flushed promptly before the dsc process exits. It does so by wrapping the tracing subscriber’s writer with a custom writer that flushes after writes.
Changes:
- Added a
FlushWriterwrapper implementingstd::io::Writethat flushes after writing. - Added a
MakeFlushWriterwrapper implementingtracing_subscriber::fmt::MakeWriterto produceFlushWriterinstances. - Updated
enable_tracingto use the flushing writer for both the default and configured tracing fmt layers.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
macOS test still failed, it appears that the flushing is only when using PS based classes, so making change in PS adapter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Still seeing random failures particulary on macOS due to traces not being flushed before
dscexits. Doing a bit more research, it seems that macOS itself caches stdio output and thus you need to explicitly flush. Fix here is to use a customFlushWriterto flushes on every write.PR Context
Fix #677