Refactor node/edge iterator locking - #2773
Open
fabianmurariu wants to merge 11 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: b60b1ba | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
5 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
5 ns/iter (± 0) |
1 ns/iter (± 0) |
5 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
8439734 ns/iter (± 52638) |
1564816 ns/iter (± 35303) |
5.39 |
lotr_graph_window_100/num_nodes |
17 ns/iter (± 0) |
5 ns/iter (± 0) |
3.40 |
lotr_graph_window_100_materialise/materialize |
8536487 ns/iter (± 43372) |
1669150 ns/iter (± 10700) |
5.11 |
lotr_graph_window_10/has_node_existing |
144 ns/iter (± 10) |
62 ns/iter (± 11) |
2.32 |
lotr_graph_window_10_materialise/materialize |
3461113 ns/iter (± 17480) |
971980 ns/iter (± 4278) |
3.56 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
2266294 ns/iter (± 17375) |
334634 ns/iter (± 1287) |
6.77 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
147 ns/iter (± 9) |
62 ns/iter (± 14) |
2.37 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1481830 ns/iter (± 10071) |
230399 ns/iter (± 2617) |
6.43 |
lotr_graph_window_50_layered/num_edges_temporal |
154622 ns/iter (± 4216) |
70121 ns/iter (± 7586) |
2.21 |
lotr_graph_window_50_layered/has_node_existing |
423 ns/iter (± 24) |
129 ns/iter (± 12) |
3.28 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/max_neighbour_degree |
839842 ns/iter (± 22674) |
386651 ns/iter (± 3853) |
2.17 |
lotr_graph_window_50_layered/graph_latest |
85045 ns/iter (± 1090) |
36649 ns/iter (± 916) |
2.32 |
lotr_graph_window_50_layered_materialise/materialize |
31823641 ns/iter (± 151580) |
3488825 ns/iter (± 24948) |
9.12 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
652584 ns/iter (± 12978) |
192686 ns/iter (± 1569) |
3.39 |
lotr_graph_persistent_window_50_layered/has_node_existing |
437 ns/iter (± 427) |
174 ns/iter (± 83) |
2.51 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
3612820 ns/iter (± 140200) |
1659940 ns/iter (± 19402) |
2.18 |
lotr_graph_persistent_window_50_layered/graph_latest |
126465 ns/iter (± 2035) |
57549 ns/iter (± 4809) |
2.20 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
54845035 ns/iter (± 232454) |
5298035 ns/iter (± 147912) |
10.35 |
This comment was automatically generated by workflow using github-action-benchmark.
fabianmurariu
force-pushed
the
refactor_node_iter
branch
from
September 10, 2026 08:02
92622f0 to
b60b1ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take locks for node and edge iterators one segment at a time instead of taking them on every node