Let voluntary filing predict from PUF-only survivor units#425
Merged
Conversation
Build M's sparse run failed in the voluntary-filing receiver: the certified frozen-support selection legitimately keeps only the PUF clone for some source units (the same L0-survivor case the SSI reporter lineage handles), and _source_receiver_rows demanded exactly one ASEC row per unit. Build J never ran this stage — it's a coverage- campaign restoration seeing full-scale selection for the first time. Prefer each unit's ASEC row and fall back to the deterministic first surviving clone (clones carry the unit's source predictors, so the surviving row predicts identically); duplicated ASEC rows remain a hard error. New test drops one unit's ASEC rows via Frame.select and pins single-prediction fanout to the survivors — it fails on the old receiver and passes with the fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build M's sparse relaunch (post-#423) failed in the voluntary-filing receiver:
US voluntary-filing support source units require exactly one ASEC row; invalid source unit(s) ['100010', …]. The certified frozen-support 57,240 selection legitimately keeps only the PUF clone for some source units — the same L0-survivor case the SSI reporter lineage already handles by design. Build J never exercised this stage (coverage-campaign restoration; first full-scale selection).Fix: prefer each unit's ASEC row; when selection kept only clones, fall back to the deterministic first surviving row (channel, then tax-unit id) — clones carry the unit's source predictors, so the surviving row predicts identically. Duplicated ASEC rows remain a hard corruption error.
Verification: new test drops one unit's ASEC rows via
Frame.selectand pins single-prediction fanout to survivors — fails on the old receiver, passes with the fix. Full voluntary-filing suite (18 tests) green; CI-ruff clean.🤖 Generated with Claude Code