Forward --asec-education-source to staged children#422
Merged
Conversation
#421 added the education sidecar to the locked run config but not to _stage_cli_args, so --stage all locked the parent context with the sidecar and spawned every child without it: the first child recomputed a config lacking asec_education_source, hit the run-context guard, and base-r4 died in six seconds. Forward the flag beside the other appended inputs, and pin the whole class with a round-trip regression test: _stage_run_config(parent) must equal _stage_run_config over the _stage_cli_args-reconstructed child argv, so any future input that enters the run config without entering the reconstruction fails in CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base-r4 died in six seconds at
source_construction: #421 added--asec-education-sourceto the locked run config but not to_stage_cli_args, so--stage alllocked the parent context with the sidecar and spawned every child without it — the child's recomputed config differed and the run-context guard (correctly) refused. Diagnosis credit: the Build M runner agent, whose report named the exact missing block.Two changes:
_stage_cli_argsbeside the other appended inputs.test_stage_cli_round_trips_the_locked_run_config: parse a full parent argv → reconstruct child argv → re-parse → assert_stage_run_configequality. Verified to FAIL without the forwarding fix and pass with it, so any future input that enters the run config without entering the reconstruction dies in CI, not in a build.🤖 Generated with Claude Code