Skip to content

fix: retain user values (config migration) #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GDjkhp wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: retain user values (config migration) #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/src/modules/config/configMigration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export function migrateConfig(oldConfig) {
tidalToken: 'sources.tidal.token'
};
for (const [oldKey, newPath] of Object.entries(migrationMap)) {
if (oldKey === newPath) continue
if (Object.hasOwn(newConfig, oldKey)) {
const value = newConfig[oldKey];
if (value === undefined)
Expand Down
3 changes: 2 additions & 1 deletion src/modules/config/configMigration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export function migrateConfig(
}

for (const [oldKey, newPath] of Object.entries(migrationMap)) {
if (oldKey === newPath) continue
if (Object.hasOwn(newConfig, oldKey)) {
const value: unknown | undefined = newConfig[oldKey]
if (value === undefined) continue
Expand Down Expand Up @@ -398,4 +399,4 @@ export async function reconcileConfigOnDisk(
`Failed to reconcile configuration on disk: ${err instanceof Error ? err.message : String(err)}. Server will continue with merged in-memory configuration.`
)
}
}
}
Loading