Skip to content

Improve raster of timings - #61

Open
ckolbPTB wants to merge 16 commits into
PTB-MR:mainfrom
ckolbPTB:improve_rastering
Open

Improve raster of timings#61
ckolbPTB wants to merge 16 commits into
PTB-MR:mainfrom
ckolbPTB:improve_rastering

Conversation

@ckolbPTB

@ckolbPTB ckolbPTB commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Feb 8, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/.local/lib/python3.12/site-packages/mrseq
   _version.py770%2–9
/home/runner/.local/lib/python3.12/site-packages/mrseq/preparations
   t2_prep.py55198%198
/home/runner/.local/lib/python3.12/site-packages/mrseq/sequences
   epi2d_fid.py128993%256, 359, 416–421, 433, 439
   epi2d_se.py1481292%204–206, 317, 420, 477–482, 494, 500
   grpe_flash_dixon.py2051891%120, 123, 188, 205–207, 329, 348, 399, 409, 511, 580–585, 597, 603
   radial_flash.py1411192%102, 105, 260, 354, 412–417, 429, 435
   spiral_flash.py1201092%95, 231, 320, 370–375, 387, 393
   t1_inv_rec_gre_single_line.py94990%163, 264, 307–312, 331, 337
   t1_inv_rec_se_single_line.py107992%220, 325, 384–389, 408, 414
   t1_molli_bssfp.py1421391%217, 283–285, 300, 384, 438–443, 455, 461
   t1_t2_spiral_cmrf.py1491292%89, 95, 116, 170, 399, 446–451, 465, 471
   t1rho_se_single_line.py103892%319, 376–381, 400, 406
   t2_multi_echo_se_single_line.py97991%163, 269, 322–327, 345, 351
   t2_t2prep_flash.py1441590%104, 227, 244, 278–280, 292, 376, 438–443, 455, 461
   t2star_multi_echo_flash.py1461490%114, 233, 280–282, 294, 399, 462–467, 479, 485
/home/runner/.local/lib/python3.12/site-packages/mrseq/utils
   EpiReadout.py3339073%52, 61, 193, 197, 248, 327, 330–341, 463, 516–600, 746–752, 772–817
   cartesian_sampling.py37295%38, 80
   sequence_helper.py66494%107, 135–136, 164
   spiral_sampling.py67199%79
TOTAL247925490% 

Tests Skipped Failures Errors Time
1530 0 💤 2 ❌ 0 🔥 4m 32s ⏱️

@ckolbPTB
ckolbPTB marked this pull request as ready for review March 24, 2026 09:49
@ckolbPTB
ckolbPTB requested a review from schuenke March 24, 2026 09:49
@schuenke

Copy link
Copy Markdown
Contributor

Are the raster timings in the EPI scripts correct already, or do we have to do some adjustments there as well?

@ckolbPTB

Copy link
Copy Markdown
Contributor Author

They need to be adapted. I will also add one more case with non-integer raster times.

@ckolbPTB

ckolbPTB commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

There is still a problem with the ADC dead time. For our current system defaults that is very short so it is never a problem. For other systems it can be longer.

The ADC dead time I guess is only important between RF pulses and ADC events but most interpreters will simply throw an error if the time between block border and ADC event is less than the ADC dead time, independent if there is an RF event beforehand.

One option would be to simply ensure that the gy blip gradient durations are always at least 2 * ADC dead time: https://github.com/ckolbPTB/mrseq/blob/e50a366dad901328fefc66c4bcd9e10b471c0416/src/mrseq/utils/EpiReadout.py#L225

@schuenke Can you think of a smarter way of how to solve this?

@ckolbPTB

Copy link
Copy Markdown
Contributor Author

Needs pulseq/pypulseq#417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants